third_party/WebKit/Source/bindings/scripts/v8_interface.py - Issue 1466563003: Make [TypeChecking=Interface] the default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 1466563003: Make [TypeChecking=Interface] the default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

index 70fd6e266f7ba8017bac9d2b3c37b32d8f298ca2..fbb57bb2a0e039050be9b7b966d397f9854649e8 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

@@ -1355,7 +1355,7 @@ def property_setter(setter, interface):

is_call_with_script_state = v8_utilities.has_extended_attribute_value(setter, 'CallWith', 'ScriptState')

is_raises_exception = 'RaisesException' in extended_attributes

- # [TypeChecking=Interface] / [LegacyInterfaceTypeChecking]

+ # [LegacyInterfaceTypeChecking]

has_type_checking_interface = (

not is_legacy_interface_type_checking(interface, setter) and

idl_type.is_wrapper_type)