third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl - Issue 1466563003: Make [TypeChecking=Interface] the default

Unified Diff: third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl

Issue 1466563003: Make [TypeChecking=Interface] the default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/idls/core/TestInterface2.idl ('k') | third_party/WebKit/Source/bindings/tests/idls/core/TestPartialInterface4.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl

diff --git a/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl b/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl

index a7b383ceb945eae800e1d3fd6789558be6961092..8258bcef036a6f0aca0c9294f7a7a2de2a76f161 100644

--- a/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl

+++ b/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl

@@ -207,7 +207,7 @@ interface TestObject {

[PutForwards=hrefCallWith] readonly attribute TestNode locationWithCallWith;

[PutForwards=hrefByteString] readonly attribute TestNode locationByteString;

[PerWorldBindings, PutForwards=href] readonly attribute TestNode locationWithPerWorldBindings;

- [TypeChecking=Interface, PutForwards=href] readonly attribute TestNode locationTypeCheckingInterface;

+ [PutForwards=href, LegacyInterfaceTypeChecking] readonly attribute TestNode locationLegacyInterfaceTypeChecking;

[PutForwards=attr1] readonly attribute TestInterfaceGarbageCollected locationGarbageCollected;

[PutForwards=attr1] readonly attribute TestInterfaceWillBeGarbageCollected locationWillBeGarbageCollected;

[RaisesException] attribute long raisesExceptionLongAttribute;

@@ -254,9 +254,9 @@ interface TestObject {

[TreatReturnedNullStringAs=Undefined] attribute ByteString treatReturnedNullStringAsUndefinedByteStringAttribute;

[TreatReturnedNullStringAs=Null] attribute USVString treatReturnedNullStringAsNullUSVStringAttribute;

[TreatReturnedNullStringAs=Undefined] attribute USVString treatReturnedNullStringAsUndefinedUSVStringAttribute;

- [TypeChecking=Interface] attribute float typeCheckingInterfaceFloatAttribute; // nop for non-interface types

- [TypeChecking=Interface] attribute TestInterface typeCheckingInterfaceTestInterfaceAttribute;

- [TypeChecking=Interface] attribute TestInterface? typeCheckingInterfaceTestInterfaceOrNullAttribute;

+ [LegacyInterfaceTypeChecking] attribute float legacyInterfaceTypeCheckingFloatAttribute; // nop for non-interface types

+ [LegacyInterfaceTypeChecking] attribute TestInterface legacyInterfaceTypeCheckingTestInterfaceAttribute;

+ [LegacyInterfaceTypeChecking] attribute TestInterface? legacyInterfaceTypeCheckingTestInterfaceOrNullAttribute;

[Reflect, URL] attribute DOMString urlStringAttribute;

[Reflect=reflectUrlAttribute, URL] attribute DOMString urlStringAttribute;

[Unforgeable] attribute long unforgeableLongAttribute;

@@ -575,12 +575,12 @@ interface TestObject {

[TreatReturnedNullStringAs=Undefined] ByteString treatReturnedNullStringAsUndefinedByteStringMethod();

[TreatReturnedNullStringAs=Null] USVString treatReturnedNullStringAsNullUSVStringMethod();

[TreatReturnedNullStringAs=Undefined] USVString treatReturnedNullStringAsUndefinedUSVStringMethod();

- [TypeChecking=Interface] void typeCheckingInterfaceVoidMethodTestInterfaceEmptyArg(TestInterfaceEmpty testInterfaceEmptyArg);

- [TypeChecking=Interface] void typeCheckingInterfaceVoidMethodTestInterfaceEmptyVariadicArg(TestInterfaceEmpty... testInterfaceEmptyArg);

+ [LegacyInterfaceTypeChecking] void legacyInterfaceTypeCheckingVoidMethodTestInterfaceEmptyArg(TestInterfaceEmpty testInterfaceEmptyArg);

+ [LegacyInterfaceTypeChecking] void legacyInterfaceTypeCheckingVoidMethodTestInterfaceEmptyVariadicArg(TestInterfaceEmpty... testInterfaceEmptyArg);

// Avoid redundant type checking

- [TypeChecking=Interface] void useToImpl4ArgumentsCheckingIfPossibleWithOptionalArg(Node node1, optional Node node2);

- [TypeChecking=Interface] void useToImpl4ArgumentsCheckingIfPossibleWithNullableArg(Node node1, Node? node2);

- [TypeChecking=Interface] void useToImpl4ArgumentsCheckingIfPossibleWithUndefinedArg(Node node1, [Default=Undefined] optional Node node2);

+ void useToImpl4ArgumentsCheckingIfPossibleWithOptionalArg(Node node1, optional Node node2);

+ void useToImpl4ArgumentsCheckingIfPossibleWithNullableArg(Node node1, Node? node2);

+ void useToImpl4ArgumentsCheckingIfPossibleWithUndefinedArg(Node node1, [Default=Undefined] optional Node node2);

[Unforgeable] void unforgeableVoidMethod();

void voidMethodTestInterfaceGarbageCollectedSequenceArg(sequence<TestInterfaceGarbageCollected> testInterfaceGarbageCollectedSequenceArg);

void voidMethodTestInterfaceGarbageCollectedArrayArg(TestInterfaceGarbageCollected[] testInterfaceGarbageCollectedArrayArg);