Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: third_party/WebKit/Source/core/editing/Selection.idl

Issue 1466563003: Make [TypeChecking=Interface] the default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/Selection.idl
diff --git a/third_party/WebKit/Source/core/editing/Selection.idl b/third_party/WebKit/Source/core/editing/Selection.idl
index 4456922470279cb1cf95343cb74d84ab59e24a44..0cc455d1129e1932ae97f75d40436b9c425af25b 100644
--- a/third_party/WebKit/Source/core/editing/Selection.idl
+++ b/third_party/WebKit/Source/core/editing/Selection.idl
@@ -42,30 +42,30 @@
[MeasureAs=SelectionRangeCount] readonly attribute long rangeCount;
[MeasureAs=SelectionType] readonly attribute DOMString type;
[MeasureAs=SelectionGetRangeAt, RaisesException] Range getRangeAt(long index);
- [MeasureAs=SelectionAddRange] void addRange(Range range);
+ [MeasureAs=SelectionAddRange, LegacyInterfaceTypeChecking] void addRange(Range range);
// TODO(yoichio): Implement removeRange. crbug.com/391673
//void removeRange(Range range);
[MeasureAs=SelectionRemoveAllRanges] void removeAllRanges();
[MeasureAs=SelectionEmpty] void empty();
// TODO(yoichio): The node argument should not be nullable. crbug.com/391673
// TODO(philipj): The offset argument should not have a default value.
- [MeasureAs=SelectionCollapse, RaisesException] void collapse(Node? node, optional long offset = 0);
+ [MeasureAs=SelectionCollapse, RaisesException, LegacyInterfaceTypeChecking] void collapse(Node? node, optional long offset = 0);
// TODO(yoichio): The node argument should not be nullable. crbug.com/391673
// TODO(philipj): The offset argument should not have a default value.
- [ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException] void setPosition(Node? node, optional long offset = 0);
+ [ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException, LegacyInterfaceTypeChecking] void setPosition(Node? node, optional long offset = 0);
[MeasureAs=SelectionCollapseToStart, RaisesException] void collapseToStart();
[MeasureAs=SelectionCollapseToEnd, RaisesException] void collapseToEnd();
// TODO(philipj): The offset argument should not have a default value.
- [MeasureAs=SelectionExtend, RaisesException, TypeChecking=Interface] void extend(Node node, optional long offset = 0);
+ [MeasureAs=SelectionExtend, RaisesException] void extend(Node node, optional long offset = 0);
// TODO(philipj): The arguments should be anchorNode, anchorOffset,
// focusNode and focusOffset, and none of them should be optional.
- [MeasureAs=SelectionSetBaseAndExtent, RaisesException] void setBaseAndExtent([Default=Undefined] optional Node baseNode,
- [Default=Undefined] optional long baseOffset,
- [Default=Undefined] optional Node extentNode,
- [Default=Undefined] optional long extentOffset);
- [MeasureAs=SelectionSelectAllChildren, RaisesException, TypeChecking=Interface] void selectAllChildren(Node node);
+ [MeasureAs=SelectionSetBaseAndExtent, RaisesException, LegacyInterfaceTypeChecking] void setBaseAndExtent([Default=Undefined] optional Node baseNode,
+ [Default=Undefined] optional long baseOffset,
+ [Default=Undefined] optional Node extentNode,
+ [Default=Undefined] optional long extentOffset);
+ [MeasureAs=SelectionSelectAllChildren, RaisesException] void selectAllChildren(Node node);
[MeasureAs=SelectionDeleteDromDocument, CustomElementCallbacks] void deleteFromDocument();
- [MeasureAs=SelectionContainsNode, TypeChecking=Interface] boolean containsNode(Node node, optional boolean allowPartialContainment = false);
+ [MeasureAs=SelectionContainsNode] boolean containsNode(Node node, optional boolean allowPartialContainment = false);
// TODO(philipj): The spec does not use [NotEnumerable]. See also:
// https://codereview.chromium.org/345983004/
// https://www.w3.org/Bugs/Public/show_bug.cgi?id=26179
« no previous file with comments | « third_party/WebKit/Source/core/dom/URL.idl ('k') | third_party/WebKit/Source/core/events/CompositionEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698