[Autofill] No longer pass FormStructure pointers in ParseQueryResponse.

[Autofill] No longer pass FormStructure pointers in ParseQueryResponse.

Use form signatures to look up forms in |form_structures_|, which is
guaranteed to be valid.

BUG=557713, 557740, 557800
TEST=Existing

Committed: https://crrev.com/29fda7fc8af99768dd93391366408e05c656e154
Cr-Commit-Position: refs/heads/master@{#360580}

[Mathieu, 2015-11-18 17:45:56]

mathp@chromium.org changed reviewers:
+ vabr@chromium.org

[Mathieu, 2015-11-18 17:45:57]

Hi, 

Please take a look!

[Mathieu, 2015-11-18 17:46:10]

Patchset #1 (id:1) has been deleted

[vabr (Chromium), 2015-11-19 07:56:04]

Thanks, Mathieu, the fix LGTM.

However, did you manage to reproduce the crash by resetting the AutofillManager?
It would be great to have that as a test to prevent future regressions.

Cheers,
Vaclav

https://codereview.chromium.org/1457793002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/form_structure.h (right):

https://codereview.chromium.org/1457793002/diff/20001/components/autofill/cor...
components/autofill/core/browser/form_structure.h:75: // |encoded_signatures|,
respectively. All valid fields are encoded in
nit: No need for 'respectively' any more.

[Mathieu, 2015-11-19 13:20:55]

Thanks! You're right, I've added a test that resetting the manager certainly
doesn't crash, and doesn't call ParseQueryResponse (as expected). 

Will submit today, let me know if you have last minute comments.

https://codereview.chromium.org/1457793002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/form_structure.h (right):

https://codereview.chromium.org/1457793002/diff/20001/components/autofill/cor...
components/autofill/core/browser/form_structure.h:75: // |encoded_signatures|,
respectively. All valid fields are encoded in
On 2015/11/19 07:56:04, vabr (Chromium) wrote:
> nit: No need for 'respectively' any more.

Done.

[vabr (Chromium), 2015-11-19 13:40:18]

LGTM, thanks!
Vaclav

[Mathieu, 2015-11-19 14:02:48]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2015-11-19 14:03:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457793002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457793002/40001

[commit-bot: I haz the power, 2015-11-19 14:54:39]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-11-19 14:55:16]

Patchset 2 (id:??) landed as
https://crrev.com/29fda7fc8af99768dd93391366408e05c656e154
Cr-Commit-Position: refs/heads/master@{#360580}