components/autofill/core/browser/autofill_manager.h - Issue 1457793002: [Autofill] No longer pass FormStructure pointers in ParseQueryResponse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 1457793002: [Autofill] No longer pass FormStructure pointers in ParseQueryResponse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added AutofillManager tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_download_manager_unittest.cc ('k') | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.h

diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h

index f1ab96d8965732b24ad36b63ceecfd8af2ac735f..ebc4005ab20a18a58bb90d6ce49142658c0f64d6 100644

--- a/components/autofill/core/browser/autofill_manager.h

+++ b/components/autofill/core/browser/autofill_manager.h

@@ -248,7 +248,7 @@ class AutofillManager : public AutofillDownloadManager::Observer,

// AutofillDownloadManager::Observer:

void OnLoadedServerPredictions(

const std::string& response_xml,

- const std::vector<FormStructure*>& queried_forms) override;

+ const std::vector<std::string>& form_signatures) override;

// CardUnmaskDelegate:

void OnUnmaskResponse(const UnmaskResponse& response) override;

@@ -518,6 +518,10 @@ class AutofillManager : public AutofillDownloadManager::Observer,

FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,

FormSubmittedAutocompleteEnabled);

FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,

+ OnLoadedServerPredictions);

+ FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,

+ OnLoadedServerPredictions_ResetManager);

+ FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,

AutocompleteSuggestions_SomeWhenAutofillDisabled);

FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,

AutocompleteSuggestions_SomeWhenAutofillEmpty);