components/autofill/core/browser/autofill_download_manager_unittest.cc - Issue 1457793002: [Autofill] No longer pass FormStructure pointers in ParseQueryResponse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_download_manager_unittest.cc

Issue 1457793002: [Autofill] No longer pass FormStructure pointers in ParseQueryResponse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added AutofillManager tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_download_manager.cc ('k') | components/autofill/core/browser/autofill_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_download_manager_unittest.cc

diff --git a/components/autofill/core/browser/autofill_download_manager_unittest.cc b/components/autofill/core/browser/autofill_download_manager_unittest.cc

index 8562863ca77d5562e939225afdd19f0c36d04309..23730914012573c807c7b17b1ce7de242349f1c1 100644

--- a/components/autofill/core/browser/autofill_download_manager_unittest.cc

+++ b/components/autofill/core/browser/autofill_download_manager_unittest.cc

@@ -82,7 +82,7 @@ class AutofillDownloadTest : public AutofillDownloadManager::Observer,

// AutofillDownloadManager::Observer implementation.

void OnLoadedServerPredictions(

const std::string& response_xml,

- const std::vector<FormStructure*>& queried_forms) override {

+ const std::vector<std::string>& form_signatures) override {

ResponseData response;

response.response = response_xml;

response.type_of_response = QUERY_SUCCESSFULL;