Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: components/autofill/core/browser/form_structure.h

Issue 1457793002: [Autofill] No longer pass FormStructure pointers in ParseQueryResponse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added AutofillManager tests Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/form_structure.h
diff --git a/components/autofill/core/browser/form_structure.h b/components/autofill/core/browser/form_structure.h
index 14cdd1da1f237c4fb50591cc29507a9e231bd8f3..875342045c45039948c708c7cc9738ec1aaa1bd1 100644
--- a/components/autofill/core/browser/form_structure.h
+++ b/components/autofill/core/browser/form_structure.h
@@ -71,15 +71,13 @@ class FormStructure {
// Encodes the XML query request for the set of |forms| that are valid (see
// implementation for details on which forms are not included in the query).
- // The forms and form signatures used in the Query request are output in
- // |queried_forms| and |encoded_signatures|, respectively. All valid fields
- // are encoded in |encoded_xml|. For example, there are three valid forms,
- // with 2, 4, and 3 fields. The returned XML would have type info for 9
- // fields, first two of which would be for the first form, next 4 for the
- // second, and the rest is for the third.
+ // The form signatures used in the Query request are output in
+ // |encoded_signatures|. All valid fields are encoded in |encoded_xml|. For
+ // example, there are three valid forms, with 2, 4, and 3 fields. The returned
+ // XML would have type info for 9 fields, first two of which would be for the
+ // first form, next 4 for the second, and the rest is for the third.
static bool EncodeQueryRequest(const std::vector<FormStructure*>& forms,
std::vector<std::string>* encoded_signatures,
- std::vector<FormStructure*>* queried_forms,
std::string* encoded_xml);
// Parses the field types from the server query response. |forms| must be the
« no previous file with comments | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/autofill/core/browser/form_structure.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698