Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: components/autofill/core/browser/autofill_download_manager.cc

Issue 1457793002: [Autofill] No longer pass FormStructure pointers in ParseQueryResponse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added AutofillManager tests Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_download_manager.cc
diff --git a/components/autofill/core/browser/autofill_download_manager.cc b/components/autofill/core/browser/autofill_download_manager.cc
index 7676d1e88b108334584b62c90d85c6c60c327647..17ffec100d3063be83005ce038720c397ed7d036 100644
--- a/components/autofill/core/browser/autofill_download_manager.cc
+++ b/components/autofill/core/browser/autofill_download_manager.cc
@@ -65,7 +65,6 @@ GURL GetRequestUrl(AutofillDownloadManager::RequestType request_type) {
struct AutofillDownloadManager::FormRequestData {
std::vector<std::string> form_signatures;
- std::vector<FormStructure*> queried_forms;
RequestType request_type;
};
@@ -108,7 +107,6 @@ bool AutofillDownloadManager::StartQueryRequest(
std::string form_xml;
FormRequestData request_data;
if (!FormStructure::EncodeQueryRequest(forms, &request_data.form_signatures,
- &request_data.queried_forms,
&form_xml)) {
return false;
}
@@ -122,7 +120,7 @@ bool AutofillDownloadManager::StartQueryRequest(
<< "from the cache, form signatures: "
<< GetCombinedSignature(request_data.form_signatures);
observer_->OnLoadedServerPredictions(query_data,
- request_data.queried_forms);
+ request_data.form_signatures);
return true;
}
@@ -345,7 +343,7 @@ void AutofillDownloadManager::OnURLFetchComplete(
if (it->second.request_type == AutofillDownloadManager::REQUEST_QUERY) {
CacheQueryRequest(it->second.form_signatures, response_body);
observer_->OnLoadedServerPredictions(response_body,
- it->second.queried_forms);
+ it->second.form_signatures);
} else {
double new_positive_upload_rate = 0;
double new_negative_upload_rate = 0;

Powered by Google App Engine
This is Rietveld 408576698