Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: components/autofill/core/browser/autofill_manager.h

Issue 1457793002: [Autofill] No longer pass FormStructure pointers in ParseQueryResponse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added AutofillManager tests Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 241
242 // Exposed for testing. 242 // Exposed for testing.
243 void set_payments_client(payments::PaymentsClient* payments_client) { 243 void set_payments_client(payments::PaymentsClient* payments_client) {
244 payments_client_.reset(payments_client); 244 payments_client_.reset(payments_client);
245 } 245 }
246 246
247 private: 247 private:
248 // AutofillDownloadManager::Observer: 248 // AutofillDownloadManager::Observer:
249 void OnLoadedServerPredictions( 249 void OnLoadedServerPredictions(
250 const std::string& response_xml, 250 const std::string& response_xml,
251 const std::vector<FormStructure*>& queried_forms) override; 251 const std::vector<std::string>& form_signatures) override;
252 252
253 // CardUnmaskDelegate: 253 // CardUnmaskDelegate:
254 void OnUnmaskResponse(const UnmaskResponse& response) override; 254 void OnUnmaskResponse(const UnmaskResponse& response) override;
255 void OnUnmaskPromptClosed() override; 255 void OnUnmaskPromptClosed() override;
256 256
257 // payments::PaymentsClientDelegate: 257 // payments::PaymentsClientDelegate:
258 IdentityProvider* GetIdentityProvider() override; 258 IdentityProvider* GetIdentityProvider() override;
259 void OnDidGetRealPan(AutofillClient::PaymentsRpcResult result, 259 void OnDidGetRealPan(AutofillClient::PaymentsRpcResult result,
260 const std::string& real_pan) override; 260 const std::string& real_pan) override;
261 void OnDidGetUploadDetails( 261 void OnDidGetUploadDetails(
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, SaneMetricsWithCacheMismatch); 511 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, SaneMetricsWithCacheMismatch);
512 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, TestExternalDelegate); 512 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, TestExternalDelegate);
513 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 513 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
514 TestTabContentsWithExternalDelegate); 514 TestTabContentsWithExternalDelegate);
515 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, 515 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest,
516 UserHappinessFormLoadAndSubmission); 516 UserHappinessFormLoadAndSubmission);
517 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction); 517 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
518 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 518 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
519 FormSubmittedAutocompleteEnabled); 519 FormSubmittedAutocompleteEnabled);
520 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 520 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
521 OnLoadedServerPredictions);
522 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
523 OnLoadedServerPredictions_ResetManager);
524 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
521 AutocompleteSuggestions_SomeWhenAutofillDisabled); 525 AutocompleteSuggestions_SomeWhenAutofillDisabled);
522 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 526 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
523 AutocompleteSuggestions_SomeWhenAutofillEmpty); 527 AutocompleteSuggestions_SomeWhenAutofillEmpty);
524 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 528 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
525 AutocompleteSuggestions_NoneWhenAutofillPresent); 529 AutocompleteSuggestions_NoneWhenAutofillPresent);
526 FRIEND_TEST_ALL_PREFIXES( 530 FRIEND_TEST_ALL_PREFIXES(
527 AutofillManagerTest, 531 AutofillManagerTest,
528 AutocompleteSuggestions_AutofillDisabledAndFieldShouldNotAutocomplete); 532 AutocompleteSuggestions_AutofillDisabledAndFieldShouldNotAutocomplete);
529 FRIEND_TEST_ALL_PREFIXES( 533 FRIEND_TEST_ALL_PREFIXES(
530 AutofillManagerTest, 534 AutofillManagerTest,
531 AutocompleteSuggestions_NoneWhenAutofillEmptyFieldShouldNotAutocomplete); 535 AutocompleteSuggestions_NoneWhenAutofillEmptyFieldShouldNotAutocomplete);
532 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 536 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
533 AutocompleteOffRespectedForAutocomplete); 537 AutocompleteOffRespectedForAutocomplete);
534 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 538 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
535 DontSaveCvcInAutocompleteHistory); 539 DontSaveCvcInAutocompleteHistory);
536 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSavePaymentsCard); 540 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSavePaymentsCard);
537 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, FillInUpdatedExpirationDate); 541 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, FillInUpdatedExpirationDate);
538 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 542 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
539 }; 543 };
540 544
541 } // namespace autofill 545 } // namespace autofill
542 546
543 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 547 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698