Revert of Calculate paint invalidation rect for scrollbars

Revert of Calculate paint invalidation rect for scrollbars (patchset #14 id:320001 of https://codereview.chromium.org/1406133005/ )

Reason for revert:
Speculative, very likely caused https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6?numbuilds=200 to turn red

Original issue's description:
> Calculate paint invalidation rect for scrollbars
> 
> Remove eager invalidation of scrollbars except when they are removed.
> Invalidate scrollbars during paint invalidation so that we can calculate
> paint invalidation rects for them. The rects are required by
> PaintController to calculate display item bounds.
> 
> BUG=529938
> 
> Committed: https://crrev.com/77b23ecd9615ab026b9d1ffe0d8cf310f6efbc30
> Cr-Commit-Position: refs/heads/master@{#360144}

TBR=chrishtr@chromium.org,pdr@chromium.org,wkorman@chromium.org,wangxianzhu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=529938

[Nico, 2015-11-18 18:16:39]

Created Revert of Calculate paint invalidation rect for scrollbars

[commit-bot: I haz the power, 2015-11-18 18:18:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456953003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456953003/1

[Xianzhu, 2015-11-18 18:18:58]

On 2015/11/18 18:16:39, Nico (vacation Nov 18-19) wrote:
> Created Revert of Calculate paint invalidation rect for scrollbars

Just need a rebaseline for Mac 10.6 :(
We can't discover the needs of the rebaseline through CQ because we don't have a
trybot for it.

[Nico, 2015-11-18 18:19:30]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2015-11-18 18:19:50]

On 2015/11/18 18:18:58, Xianzhu wrote:
> On 2015/11/18 18:16:39, Nico (vacation Nov 18-19) wrote:
> > Created Revert of Calculate paint invalidation rect for scrollbars
> 
> Just need a rebaseline for Mac 10.6 :(
> We can't discover the needs of the rebaseline through CQ because we don't have
a
> trybot for it.

Ok, I unchecked cq. Please add a test expectations NeedsRebaseline line then.

[Xianzhu, 2015-11-18 18:20:23]

The CQ bit was unchecked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2015-11-18 18:20:50]

The CQ bit was unchecked by commit-bot@chromium.org

[alph, 2015-11-18 19:01:05]

On 2015/11/18 18:18:58, Xianzhu wrote:
> On 2015/11/18 18:16:39, Nico (vacation Nov 18-19) wrote:
> > Created Revert of Calculate paint invalidation rect for scrollbars
> 
> Just need a rebaseline for Mac 10.6 :(
> We can't discover the needs of the rebaseline through CQ because we don't have
a
> trybot for it.

Why MacOS? It's broken on XP

[Xianzhu, 2015-11-18 19:02:26]

On 2015/11/18 19:01:05, alph wrote:
> On 2015/11/18 18:18:58, Xianzhu wrote:
> > On 2015/11/18 18:16:39, Nico (vacation Nov 18-19) wrote:
> > > Created Revert of Calculate paint invalidation rect for scrollbars
> > 
> > Just need a rebaseline for Mac 10.6 :(
> > We can't discover the needs of the rebaseline through CQ because we don't
have
> a
> > trybot for it.
> 
> Why MacOS? It's broken on XP

Then we need another rebaseline for XP which has the same situation as Mac10.6:
no CQ bot to discover the needs of rebaseline.

[Nico, 2015-11-18 19:02:34]

On Wed, Nov 18, 2015 at 11:01 AM, <alph@chromium.org> wrote:

> On 2015/11/18 18:18:58, Xianzhu wrote:
>
>> On 2015/11/18 18:16:39, Nico (vacation Nov 18-19) wrote:
>> > Created Revert of Calculate paint invalidation rect for scrollbars
>>
>
> Just need a rebaseline for Mac 10.6 :(
>> We can't discover the needs of the rebaseline through CQ because we don't
>> have
>>
> a
>
>> trybot for it.
>>
>
> Why MacOS? It's broken on XP
>

The "revert reason" above is "broke mac see
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6?numbui...
"


>
> https://codereview.chromium.org/1456953003/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Nico, 2015-11-18 19:02:34]

On Wed, Nov 18, 2015 at 11:01 AM, <alph@chromium.org> wrote:

> On 2015/11/18 18:18:58, Xianzhu wrote:
>
>> On 2015/11/18 18:16:39, Nico (vacation Nov 18-19) wrote:
>> > Created Revert of Calculate paint invalidation rect for scrollbars
>>
>
> Just need a rebaseline for Mac 10.6 :(
>> We can't discover the needs of the rebaseline through CQ because we don't
>> have
>>
> a
>
>> trybot for it.
>>
>
> Why MacOS? It's broken on XP
>

The "revert reason" above is "broke mac see
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6?numbui...
"


>
> https://codereview.chromium.org/1456953003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[alph, 2015-11-18 19:06:57]

On 2015/11/18 19:02:34, Nico (vacation Nov 18-19) wrote:
> On Wed, Nov 18, 2015 at 11:01 AM, <mailto:alph@chromium.org> wrote:
> 
> > On 2015/11/18 18:18:58, Xianzhu wrote:
> >
> >> On 2015/11/18 18:16:39, Nico (vacation Nov 18-19) wrote:
> >> > Created Revert of Calculate paint invalidation rect for scrollbars
> >>
> >
> > Just need a rebaseline for Mac 10.6 :(
> >> We can't discover the needs of the rebaseline through CQ because we don't
> >> have
> >>
> > a
> >
> >> trybot for it.
> >>
> >
> > Why MacOS? It's broken on XP
> >
> 
> The "revert reason" above is "broke mac see
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6?numbui...
> "

Indeed. But it seems to broke XP as well.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/22808

> 
> 
> >
> > https://codereview.chromium.org/1456953003/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Xianzhu, 2015-11-18 19:08:00]

On 2015/11/18 19:06:57, alph wrote:
> 
> Indeed. But it seems to broke XP as well.
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/22808
> 
See #9