Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1456953003: Revert of Calculate paint invalidation rect for scrollbars (Closed)

Created:
5 years, 1 month ago by Nico
Modified:
5 years, 1 month ago
Reviewers:
chrishtr, Xianzhu, pdr., wkorman
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Calculate paint invalidation rect for scrollbars (patchset #14 id:320001 of https://codereview.chromium.org/1406133005/ ) Reason for revert: Speculative, very likely caused https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6?numbuilds=200 to turn red Original issue's description: > Calculate paint invalidation rect for scrollbars > > Remove eager invalidation of scrollbars except when they are removed. > Invalidate scrollbars during paint invalidation so that we can calculate > paint invalidation rects for them. The rects are required by > PaintController to calculate display item bounds. > > BUG=529938 > > Committed: https://crrev.com/77b23ecd9615ab026b9d1ffe0d8cf310f6efbc30 > Cr-Commit-Position: refs/heads/master@{#360144} TBR=chrishtr@chromium.org,pdr@chromium.org,wkorman@chromium.org,wangxianzhu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=529938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+647 lines, -497 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +1 line, -51 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/destroy-scrollbar-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/layout-state-only-positioned-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/resize-scrollable-div-expected.txt View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/scrollbar-invalidation-on-resize-expected.txt View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/scrollbar-invalidation-on-resize-with-border-expected.txt View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/scrollbar-parts-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/textarea-set-disabled-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-generated-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-non-fixed-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-media-query-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-html-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-width-height-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-bottom-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-percent-top-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-viewport-percent-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/squashing/iframe-inside-squashed-layer-expected.txt View 2 chunks +18 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/details-open-repaint-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/line-flow-with-floats-2-expected.txt View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/line-flow-with-floats-8-expected.txt View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/overflow-scroll-body-appear-expected.txt View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/repaint-during-scroll-with-zoom-expected.txt View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-scrollable-iframe-expected.txt View 2 chunks +20 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/shift-relative-positioned-container-with-image-addition-expected.txt View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/text-match-document-change-expected.txt View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-vertical-writing-mode-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/forms/button/button-reset-focus-by-mouse-then-keydown-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/forms/checkbox/checkbox-focus-by-mouse-then-keydown-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/forms/radio/radio-focus-by-mouse-then-keydown-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/forms/range/range-focus-by-mouse-then-keydown-expected.txt View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/forms/submit/submit-focus-by-mouse-then-keydown-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/repaint/button-checkbox-click-method-repaint-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/repaint/scroll-inside-table-cell-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/repaint/scroll-relative-table-inside-table-cell-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 9 chunks +8 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 18 chunks +90 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.cpp View 1 chunk +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +41 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 4 chunks +56 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.h View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp View 2 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp View 3 chunks +15 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp View 1 chunk +0 lines, -85 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 7 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 7 chunks +74 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 6 chunks +27 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 6 chunks +23 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 5 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 11 chunks +40 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp View 1 chunk +40 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollAnimatorTest.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
Nico
Created Revert of Calculate paint invalidation rect for scrollbars
5 years, 1 month ago (2015-11-18 18:16:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456953003/1
5 years, 1 month ago (2015-11-18 18:18:55 UTC) #2
Xianzhu
On 2015/11/18 18:16:39, Nico (vacation Nov 18-19) wrote: > Created Revert of Calculate paint invalidation ...
5 years, 1 month ago (2015-11-18 18:18:58 UTC) #3
Nico
On 2015/11/18 18:18:58, Xianzhu wrote: > On 2015/11/18 18:16:39, Nico (vacation Nov 18-19) wrote: > ...
5 years, 1 month ago (2015-11-18 18:19:50 UTC) #5
alph
On 2015/11/18 18:18:58, Xianzhu wrote: > On 2015/11/18 18:16:39, Nico (vacation Nov 18-19) wrote: > ...
5 years, 1 month ago (2015-11-18 19:01:05 UTC) #8
Xianzhu
On 2015/11/18 19:01:05, alph wrote: > On 2015/11/18 18:18:58, Xianzhu wrote: > > On 2015/11/18 ...
5 years, 1 month ago (2015-11-18 19:02:26 UTC) #9
Nico
On Wed, Nov 18, 2015 at 11:01 AM, <alph@chromium.org> wrote: > On 2015/11/18 18:18:58, Xianzhu ...
5 years, 1 month ago (2015-11-18 19:02:34 UTC) #10
Nico
On Wed, Nov 18, 2015 at 11:01 AM, <alph@chromium.org> wrote: > On 2015/11/18 18:18:58, Xianzhu ...
5 years, 1 month ago (2015-11-18 19:02:34 UTC) #11
alph
On 2015/11/18 19:02:34, Nico (vacation Nov 18-19) wrote: > On Wed, Nov 18, 2015 at ...
5 years, 1 month ago (2015-11-18 19:06:57 UTC) #12
Xianzhu
5 years, 1 month ago (2015-11-18 19:08:00 UTC) #13
Message was sent while issue was closed.
On 2015/11/18 19:06:57, alph wrote:
> 
> Indeed. But it seems to broke XP as well.
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/22808
> 
See #9

Powered by Google App Engine
This is Rietveld 408576698