Revert of Calculate paint invalidation rect for scrollbars

third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@web.de>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 181 matching lines @@
 }
 
 GraphicsLayer* PaintLayerScrollableArea::layerForScrollCorner() const
 {
     // See crbug.com/343132.
     DisableCompositingQueryAsserts disabler;
 
     return layer()->hasCompositedLayerMapping() ? layer()->compositedLayerMapping()->layerForScrollCorner() : 0;
 }
 
-void PaintLayerScrollableArea::scrollControlWasSetNeedsPaintInvalidation()
+void PaintLayerScrollableArea::invalidateScrollbarRect(Scrollbar* scrollbar, const IntRect& rect)
 {
-    box().setMayNeedPaintInvalidation();
+    // See crbug.com/343132.
+    DisableCompositingQueryAsserts disabler;
+
+    ASSERT(scrollbar == horizontalScrollbar() || scrollbar == verticalScrollbar());
+    ASSERT(scrollbar == horizontalScrollbar() ? !layerForHorizontalScrollbar() : !layerForVerticalScrollbar());
+
+    IntRect scrollRect = rect;
+    // If we are not yet inserted into the tree, there is no need to issue paint invaldiations.
+    if (!box().isLayoutView() && !box().parent())
+        return;
+
+    if (scrollbar == verticalScrollbar())
+        scrollRect.move(verticalScrollbarStart(0, box().size().width()), box().borderTop());
+    else
+        scrollRect.move(horizontalScrollbarStart(0), box().size().height() - box().borderBottom() - scrollbar->height());
+
+    if (scrollRect.isEmpty())
+        return;
+
+    LayoutRect paintInvalidationRect = LayoutRect(scrollRect);
+    box().flipForWritingMode(paintInvalidationRect);
+
+    IntRect intRect = pixelSnappedIntRect(paintInvalidationRect);
+
+    if (box().frameView()->isInPerformLayout()) {
+        addScrollbarDamage(scrollbar, intRect);
+    } else {
+        // FIXME: We should not allow paint invalidation out of paint invalidation state. crbug.com/457415
+        DisablePaintInvalidationStateAsserts disabler;
+        // We have invalidated the displayItemClient of the scrollbar, but for now we still need to
+        // invalidate the rectangles to trigger repaints.
+        box().invalidatePaintRectangleNotInvalidatingDisplayItemClients(LayoutRect(intRect));
+        box().invalidateDisplayItemClient(*scrollbar);
+    }
+}
+
+void PaintLayerScrollableArea::invalidateScrollCornerRect(const IntRect& rect)
+{
+    ASSERT(!layerForScrollCorner());
+
+    if (m_scrollCorner) {
+        // FIXME: We should not allow paint invalidation out of paint invalidation state. crbug.com/457415
+        DisablePaintInvalidationStateAsserts disabler;
+        DisableCompositingQueryAsserts compositingDisabler;
+        m_scrollCorner->invalidatePaintRectangle(LayoutRect(rect));
+        box().invalidateDisplayItemClientForNonCompositingDescendantsOf(*m_scrollCorner);
+    } else {
+        box().invalidateDisplayItemClient(box());
+    }
+    if (m_resizer) {
+        m_resizer->invalidatePaintRectangle(LayoutRect(rect));
+        box().invalidateDisplayItemClientForNonCompositingDescendantsOf(*m_resizer);
+    }
 }
 
 bool PaintLayerScrollableArea::shouldUseIntegerScrollOffset() const
 {
     Frame* frame = box().frame();
     if (frame->settings() && !frame->settings()->preferCompositingToLCDTextEnabled())
         return true;
 
     return ScrollableArea::shouldUseIntegerScrollOffset();
 }
@@ skipping 762 matching lines @@
     }
 
     return hasAnyScrollbar && ((shouldUseCustom != hasCustom) || (shouldUseCustom && didCustomScrollbarOwnerChanged));
 }
 
 void PaintLayerScrollableArea::setHasHorizontalScrollbar(bool hasScrollbar)
 {
     if (hasScrollbar == hasHorizontalScrollbar())
         return;
 
-    setScrollbarNeedsPaintInvalidation(horizontalScrollbar());
-
+    if (!hasScrollbar && !layerForHorizontalScrollbar())
+        horizontalScrollbar()->invalidate();
 
     m_scrollbarManager.setHasHorizontalScrollbar(hasScrollbar);
 
     // Destroying or creating one bar can cause our scrollbar corner to come and go. We need to update the opposite scrollbar's style.
     if (hasHorizontalScrollbar())
         horizontalScrollbar()->styleChanged();
     if (hasVerticalScrollbar())
         verticalScrollbar()->styleChanged();
 
-    setScrollCornerNeedsPaintInvalidation();
+    // These are valid because we want to invalidate display item clients on the current backing.
+    DisablePaintInvalidationStateAsserts paintInvalidationAssertDisabler;
+    DisableCompositingQueryAsserts compositingAssertDisabler;
+    invalidateScrollCorner(scrollCornerRect());
 
     // Force an update since we know the scrollbars have changed things.
     if (box().document().hasAnnotatedRegions())
         box().document().setAnnotatedRegionsDirty(true);
 }
 
 void PaintLayerScrollableArea::setHasVerticalScrollbar(bool hasScrollbar)
 {
     if (hasScrollbar == hasVerticalScrollbar())
         return;
 
-    setScrollbarNeedsPaintInvalidation(verticalScrollbar());
+    if (!hasScrollbar && !layerForVerticalScrollbar())
+        verticalScrollbar()->invalidate();
 
     m_scrollbarManager.setHasVerticalScrollbar(hasScrollbar);
 
     // Destroying or creating one bar can cause our scrollbar corner to come and go. We need to update the opposite scrollbar's style.
     if (hasHorizontalScrollbar())
         horizontalScrollbar()->styleChanged();
     if (hasVerticalScrollbar())
         verticalScrollbar()->styleChanged();
 
-    setScrollCornerNeedsPaintInvalidation();
+    // These are valid because we want to invalidate display item clients on the current backing.
+    DisablePaintInvalidationStateAsserts paintInvalidationAssertDisabler;
+    DisableCompositingQueryAsserts compositingAssertDisabler;
+    invalidateScrollCorner(scrollCornerRect());
 
     // Force an update since we know the scrollbars have changed things.
     if (box().document().hasAnnotatedRegions())
         box().document().setAnnotatedRegionsDirty(true);
 }
 
 int PaintLayerScrollableArea::verticalScrollbarWidth(OverlayScrollbarSizeRelevancy relevancy) const
 {
     if (!hasVerticalScrollbar() || (verticalScrollbar()->isOverlayScrollbar() && (relevancy == IgnoreOverlayScrollbarSize || !verticalScrollbar()->shouldParticipateInHitTesting())))
         return 0;
@@ skipping 401 matching lines @@
     destroyScrollbar(VerticalScrollbar);
 }
 
 void PaintLayerScrollableArea::ScrollbarManager::setCanDetachScrollbars(bool detach)
 {
     ASSERT(!m_hBarIsAttached || m_hBar);
     ASSERT(!m_vBarIsAttached || m_vBar);
     m_canDetachScrollbars = detach ? 1 : 0;
     if (!detach) {
         if (m_hBar && !m_hBarIsAttached)
-            destroyScrollbar(HorizontalScrollbar);
+            destroyScrollbar(HorizontalScrollbar, true);
         if (m_vBar && !m_vBarIsAttached)
-            destroyScrollbar(VerticalScrollbar);
+            destroyScrollbar(VerticalScrollbar, true);
     }
 }
 
 void PaintLayerScrollableArea::ScrollbarManager::setHasHorizontalScrollbar(bool hasScrollbar)
 {
     if (hasScrollbar) {
         // This doesn't hit in any tests, but since the equivalent code in setHasVerticalScrollbar
         // does, presumably this code does as well.
         DisableCompositingQueryAsserts disabler;
         if (!m_hBar)
@@ skipping 35 matching lines @@
         widget = Scrollbar::create(m_scrollableArea.get(), orientation, scrollbarSize);
         if (orientation == HorizontalScrollbar)
             m_scrollableArea->didAddScrollbar(widget.get(), HorizontalScrollbar);
         else
             m_scrollableArea->didAddScrollbar(widget.get(), VerticalScrollbar);
     }
     m_scrollableArea->box().document().view()->addChild(widget.get());
     return widget.release();
 }
 
-void PaintLayerScrollableArea::ScrollbarManager::destroyScrollbar(ScrollbarOrientation orientation)
+void PaintLayerScrollableArea::ScrollbarManager::destroyScrollbar(ScrollbarOrientation orientation, bool invalidate)
 {
     RefPtrWillBeMember<Scrollbar>& scrollbar = orientation == HorizontalScrollbar ? m_hBar : m_vBar;
     ASSERT(orientation == HorizontalScrollbar ? !m_hBarIsAttached: !m_vBarIsAttached);
     if (!scrollbar)
         return;
 
-    m_scrollableArea->setScrollbarNeedsPaintInvalidation(scrollbar.get());
-
+    if (invalidate) {
+        m_scrollableArea->box().invalidateDisplayItemClient(*scrollbar);
+        scrollbar->invalidate();
+    }
     if (!scrollbar->isCustomScrollbar())
         m_scrollableArea->willRemoveScrollbar(scrollbar.get(), orientation);
 
     toFrameView(scrollbar->parent())->removeChild(scrollbar.get());
     scrollbar->disconnectFromScrollableArea();
     scrollbar = nullptr;
 }
 
 DEFINE_TRACE(PaintLayerScrollableArea::ScrollbarManager)
 {
     visitor->trace(m_scrollableArea);
     visitor->trace(m_hBar);
     visitor->trace(m_vBar);
 }
 
 } // namespace blink