third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm - Issue 1456953003: Revert of Calculate paint invalidation rect for scrollbars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm

Issue 1456953003: Revert of Calculate paint invalidation rect for scrollbars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollableArea.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm

diff --git a/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm b/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm

index 4e24d784b0aec535484986268dcbf54414ba0bb4..5ff50a3825a454246088bc1c025bec91219e1bb2 100644

--- a/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm

+++ b/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm

@@ -439,7 +439,7 @@

break;

}

- _scrollbar->setNeedsPaintInvalidation();

+ _scrollbar->invalidate();

}

- (void)invalidate

@@ -1077,7 +1077,7 @@

NSScrollerStyle newStyle = [m_scrollbarPainterController.get() scrollerStyle];

if (Scrollbar* verticalScrollbar = scrollableArea()->verticalScrollbar()) {

- verticalScrollbar->setNeedsPaintInvalidation();

+ verticalScrollbar->invalidate();

ScrollbarPainter oldVerticalPainter = [m_scrollbarPainterController.get() verticalScrollerImp];

ScrollbarPainter newVerticalPainter = [NSClassFromString(@"NSScrollerImp") scrollerImpWithStyle:newStyle

@@ -1095,7 +1095,7 @@

}

if (Scrollbar* horizontalScrollbar = scrollableArea()->horizontalScrollbar()) {

- horizontalScrollbar->setNeedsPaintInvalidation();

+ horizontalScrollbar->invalidate();

ScrollbarPainter oldHorizontalPainter = [m_scrollbarPainterController.get() horizontalScrollerImp];

ScrollbarPainter newHorizontalPainter = [NSClassFromString(@"NSScrollerImp") scrollerImpWithStyle:newStyle