third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp - Issue 1456953003: Revert of Calculate paint invalidation rect for scrollbars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

Issue 1456953003: Revert of Calculate paint invalidation rect for scrollbars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp ('k') | third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

index 0d04c9f79325d85d22f779abded094152e065bba..aa46e43940742b229900fa201650938a29b61626 100644

--- a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

@@ -1040,7 +1040,7 @@

if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator())

scrollingCoordinator->scrollableAreaScrollbarLayerDidChange(m_layoutView.frameView(), HorizontalScrollbar);

if (Scrollbar* horizontalScrollbar = m_layoutView.frameView()->horizontalScrollbar())

- m_layoutView.frameView()->setScrollbarNeedsPaintInvalidation(horizontalScrollbar);

+ m_layoutView.frameView()->invalidateScrollbar(horizontalScrollbar, IntRect(IntPoint(0, 0), horizontalScrollbar->frameRect().size()));

}

if (m_layerForVerticalScrollbar) {

@@ -1049,12 +1049,12 @@

if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator())

scrollingCoordinator->scrollableAreaScrollbarLayerDidChange(m_layoutView.frameView(), VerticalScrollbar);

if (Scrollbar* verticalScrollbar = m_layoutView.frameView()->verticalScrollbar())

- m_layoutView.frameView()->setScrollbarNeedsPaintInvalidation(verticalScrollbar);

+ m_layoutView.frameView()->invalidateScrollbar(verticalScrollbar, IntRect(IntPoint(0, 0), verticalScrollbar->frameRect().size()));

}

if (m_layerForScrollCorner) {

m_layerForScrollCorner = nullptr;

- m_layoutView.frameView()->setScrollCornerNeedsPaintInvalidation();

+ m_layoutView.frameView()->invalidateScrollCorner(m_layoutView.frameView()->scrollCornerRect());

}

if (m_overflowControlsHostLayer) {