Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1456213002: Revert of [Extensions] Don't count bubble dismissal from focus loss as acknowledgment (Closed)

Created:
5 years, 1 month ago by Devlin
Modified:
5 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, msw+watch_chromium.org, tfarina, groby+bubble_chromium.org, hcarmona+bubble_chromium.org, chromium-apps-reviews_chromium.org, rouslan+bubble_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Extensions] Don't count bubble dismissal from focus loss as acknowledgment (patchset #5 id:120001 of https://codereview.chromium.org/1437683004/ ) Reason for revert: Broken MSAN: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%281%29/builds/40036 Original issue's description: > [Extensions] Don't count bubble dismissal from focus loss as acknowledgment > > Currently, if an extension message bubble is shown, and then it is dismissed > because it loses focus, we treat it the same as the user clicking the dismiss > button - which serves as acknowledging the extension. We could ignore focus > loss, but this makes for very noisy, awkward bubbles. Instead, allow the bubble > to close, but don't treat this as user acknowledgment, and show the bubble again > on next startup. > > This also involves tracking the close reason for a BubbleDelegateView. > > BUG=548269 > > Committed: https://crrev.com/1462f63a60f9c7e1e53a3a42f70afc214d67fa71 > Cr-Commit-Position: refs/heads/master@{#360373} TBR=finnur@chromium.org,sky@chromium.org,avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=548269 Committed: https://crrev.com/9389d54c588ad3bc1d57033f721cfec9972f445d Cr-Commit-Position: refs/heads/master@{#360439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -317 lines) Patch
M chrome/browser/extensions/dev_mode_bubble_delegate.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/dev_mode_bubble_delegate.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller.h View 4 chunks +10 lines, -23 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller.cc View 9 chunks +17 lines, -41 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller_unittest.cc View 10 chunks +14 lines, -94 lines 0 comments Download
M chrome/browser/extensions/ntp_overridden_bubble_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/ntp_overridden_bubble_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/proxy_overridden_bubble_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/proxy_overridden_bubble_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/settings_api_bubble_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/settings_api_bubble_delegate.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/extensions/suspicious_extension_bubble_delegate.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/suspicious_extension_bubble_delegate.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_message_bubble_bridge.mm View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac_unittest.mm View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_toolbar_icon_surfacing_bubble_views_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ui/views/bubble/bubble_delegate.h View 4 chunks +0 lines, -12 lines 0 comments Download
M ui/views/bubble/bubble_delegate.cc View 5 chunks +5 lines, -17 lines 0 comments Download
M ui/views/bubble/bubble_delegate_unittest.cc View 3 chunks +0 lines, -55 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.h View 3 chunks +0 lines, -6 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Devlin
Created Revert of [Extensions] Don't count bubble dismissal from focus loss as acknowledgment
5 years, 1 month ago (2015-11-18 23:11:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456213002/1
5 years, 1 month ago (2015-11-18 23:11:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 23:15:33 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 23:16:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9389d54c588ad3bc1d57033f721cfec9972f445d
Cr-Commit-Position: refs/heads/master@{#360439}

Powered by Google App Engine
This is Rietveld 408576698