Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: chrome/browser/extensions/settings_api_bubble_delegate.h

Issue 1456213002: Revert of [Extensions] Don't count bubble dismissal from focus loss as acknowledgment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_SETTINGS_API_BUBBLE_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_SETTINGS_API_BUBBLE_DELEGATE_H_
6 #define CHROME_BROWSER_EXTENSIONS_SETTINGS_API_BUBBLE_DELEGATE_H_ 6 #define CHROME_BROWSER_EXTENSIONS_SETTINGS_API_BUBBLE_DELEGATE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 21 matching lines...) Expand all
32 const base::string16& overflow_count) const override; 32 const base::string16& overflow_count) const override;
33 GURL GetLearnMoreUrl() const override; 33 GURL GetLearnMoreUrl() const override;
34 base::string16 GetActionButtonLabel() const override; 34 base::string16 GetActionButtonLabel() const override;
35 base::string16 GetDismissButtonLabel() const override; 35 base::string16 GetDismissButtonLabel() const override;
36 bool ShouldCloseOnDeactivate() const override; 36 bool ShouldCloseOnDeactivate() const override;
37 bool ShouldShowExtensionList() const override; 37 bool ShouldShowExtensionList() const override;
38 bool ShouldHighlightExtensions() const override; 38 bool ShouldHighlightExtensions() const override;
39 bool ShouldLimitToEnabledExtensions() const override; 39 bool ShouldLimitToEnabledExtensions() const override;
40 void LogExtensionCount(size_t count) override; 40 void LogExtensionCount(size_t count) override;
41 void LogAction(ExtensionMessageBubbleController::BubbleAction) override; 41 void LogAction(ExtensionMessageBubbleController::BubbleAction) override;
42 const char* GetKey() override;
43 42
44 private: 43 private:
45 // The type of settings override this bubble will report on. This can be, for 44 // The type of settings override this bubble will report on. This can be, for
46 // example, a bubble to notify the user that the search engine has been 45 // example, a bubble to notify the user that the search engine has been
47 // changed by an extension (or homepage/startup pages/etc). 46 // changed by an extension (or homepage/startup pages/etc).
48 SettingsApiOverrideType type_; 47 SettingsApiOverrideType type_;
49 48
50 // The ID of the extension we are showing the bubble for. 49 // The ID of the extension we are showing the bubble for.
51 std::string extension_id_; 50 std::string extension_id_;
52 51
53 DISALLOW_COPY_AND_ASSIGN(SettingsApiBubbleDelegate); 52 DISALLOW_COPY_AND_ASSIGN(SettingsApiBubbleDelegate);
54 }; 53 };
55 54
56 } // namespace extensions 55 } // namespace extensions
57 56
58 #endif // CHROME_BROWSER_EXTENSIONS_SETTINGS_API_BUBBLE_DELEGATE_H_ 57 #endif // CHROME_BROWSER_EXTENSIONS_SETTINGS_API_BUBBLE_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698