chrome/browser/extensions/ntp_overridden_bubble_delegate.cc - Issue 1456213002: Revert of [Extensions] Don't count bubble dismissal from focus loss as acknowledgment

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/ntp_overridden_bubble_delegate.cc

Issue 1456213002: Revert of [Extensions] Don't count bubble dismissal from focus loss as acknowledgment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/ntp_overridden_bubble_delegate.h ('k') | chrome/browser/extensions/proxy_overridden_bubble_delegate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/ntp_overridden_bubble_delegate.h"	5 #include "chrome/browser/extensions/ntp_overridden_bubble_delegate.h"

6	6

7 #include "base/metrics/histogram.h"	7 #include "base/metrics/histogram.h"

8 #include "chrome/browser/extensions/extension_service.h"	8 #include "chrome/browser/extensions/extension_service.h"

9 #include "chrome/browser/extensions/extension_web_ui.h"	9 #include "chrome/browser/extensions/extension_web_ui.h"

10 #include "chrome/browser/profiles/profile.h"	10 #include "chrome/browser/profiles/profile.h"

(...skipping 111 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
122 }	122 }

123	123

124 void NtpOverriddenBubbleDelegate::LogAction(	124 void NtpOverriddenBubbleDelegate::LogAction(

125 ExtensionMessageBubbleController::BubbleAction action) {	125 ExtensionMessageBubbleController::BubbleAction action) {

126 UMA_HISTOGRAM_ENUMERATION(	126 UMA_HISTOGRAM_ENUMERATION(

127 "ExtensionOverrideBubble.NtpOverriddenUserSelection",	127 "ExtensionOverrideBubble.NtpOverriddenUserSelection",

128 action,	128 action,

129 ExtensionMessageBubbleController::ACTION_BOUNDARY);	129 ExtensionMessageBubbleController::ACTION_BOUNDARY);

130 }	130 }

131	131

132 const char* NtpOverriddenBubbleDelegate::GetKey() {

133 return "NtpOverriddenBubbleDelegate";

134 }

135

136 } // namespace extensions	132 } // namespace extensions

OLD	NEW