Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: chrome/browser/extensions/settings_api_bubble_delegate.cc

Issue 1456213002: Revert of [Extensions] Don't count bubble dismissal from focus loss as acknowledgment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/settings_api_bubble_delegate.h" 5 #include "chrome/browser/extensions/settings_api_bubble_delegate.h"
6 6
7 #include "base/metrics/histogram.h" 7 #include "base/metrics/histogram.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/extensions/extension_service.h" 9 #include "chrome/browser/extensions/extension_service.h"
10 #include "chrome/browser/extensions/settings_api_helpers.h" 10 #include "chrome/browser/extensions/settings_api_helpers.h"
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 break; 231 break;
232 case BUBBLE_TYPE_SEARCH_ENGINE: 232 case BUBBLE_TYPE_SEARCH_ENGINE:
233 UMA_HISTOGRAM_ENUMERATION( 233 UMA_HISTOGRAM_ENUMERATION(
234 "ExtensionOverrideBubble.SettingsApiUserSelectionSearchEngine", 234 "ExtensionOverrideBubble.SettingsApiUserSelectionSearchEngine",
235 action, 235 action,
236 ExtensionMessageBubbleController::ACTION_BOUNDARY); 236 ExtensionMessageBubbleController::ACTION_BOUNDARY);
237 break; 237 break;
238 } 238 }
239 } 239 }
240 240
241 const char* SettingsApiBubbleDelegate::GetKey() {
242 switch (type_) {
243 case BUBBLE_TYPE_HOME_PAGE:
244 return "SettingsApiBubbleDelegate.HomePage";
245 case BUBBLE_TYPE_STARTUP_PAGES:
246 return "SettingsApiBubbleDelegate.StartupPages";
247 case BUBBLE_TYPE_SEARCH_ENGINE:
248 return "SettingsApiBubbleDelegate.SearchEngine";
249 }
250 NOTREACHED();
251 return "";
252 }
253
254 } // namespace extensions 241 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698