Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: ui/views/bubble/bubble_delegate_unittest.cc

Issue 1456213002: Revert of [Extensions] Don't count bubble dismissal from focus loss as acknowledgment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/bubble/bubble_delegate.cc ('k') | ui/views/bubble/bubble_frame_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_delegate_unittest.cc
diff --git a/ui/views/bubble/bubble_delegate_unittest.cc b/ui/views/bubble/bubble_delegate_unittest.cc
index 631acf11532b9f9ed3d65f6b8cefe97789b7150d..ec5ab14429041e07f1be881f84e456b9d9645894 100644
--- a/ui/views/bubble/bubble_delegate_unittest.cc
+++ b/ui/views/bubble/bubble_delegate_unittest.cc
@@ -3,10 +3,8 @@
// found in the LICENSE file.
#include "ui/base/hit_test.h"
-#include "ui/events/event_utils.h"
#include "ui/views/bubble/bubble_delegate.h"
#include "ui/views/bubble/bubble_frame_view.h"
-#include "ui/views/controls/button/label_button.h"
#include "ui/views/test/test_widget_observer.h"
#include "ui/views/test/views_test_base.h"
#include "ui/views/widget/widget.h"
@@ -37,10 +35,6 @@
// BubbleDelegateView overrides:
View* GetInitiallyFocusedView() override { return view_; }
gfx::Size GetPreferredSize() const override { return gfx::Size(200, 200); }
-
- BubbleFrameView* GetBubbleFrameViewForTest() const {
- return GetBubbleFrameView();
- }
private:
View* view_;
@@ -267,53 +261,4 @@
EXPECT_FALSE(bubble_widget->CanActivate());
}
-TEST_F(BubbleDelegateTest, CloseReasons) {
- {
- scoped_ptr<Widget> anchor_widget(CreateTestWidget());
- BubbleDelegateView* bubble_delegate = new BubbleDelegateView(
- anchor_widget->GetContentsView(), BubbleBorder::NONE);
- bubble_delegate->set_close_on_deactivate(true);
- Widget* bubble_widget = BubbleDelegateView::CreateBubble(bubble_delegate);
- bubble_widget->Show();
- anchor_widget->Activate();
- EXPECT_TRUE(bubble_widget->IsClosed());
- EXPECT_EQ(BubbleDelegateView::CloseReason::DEACTIVATION,
- bubble_delegate->close_reason());
- }
-
- {
- scoped_ptr<Widget> anchor_widget(CreateTestWidget());
- BubbleDelegateView* bubble_delegate = new BubbleDelegateView(
- anchor_widget->GetContentsView(), BubbleBorder::NONE);
- bubble_delegate->set_close_on_esc(true);
- Widget* bubble_widget = BubbleDelegateView::CreateBubble(bubble_delegate);
- bubble_widget->Show();
- // Cast as a test hack to access AcceleratorPressed() (which is protected
- // in BubbleDelegate).
- static_cast<View*>(bubble_delegate)
- ->AcceleratorPressed(ui::Accelerator(ui::VKEY_ESCAPE, ui::EF_NONE));
- EXPECT_TRUE(bubble_widget->IsClosed());
- EXPECT_EQ(BubbleDelegateView::CloseReason::ESCAPE,
- bubble_delegate->close_reason());
- }
-
- {
- scoped_ptr<Widget> anchor_widget(CreateTestWidget());
- TestBubbleDelegateView* bubble_delegate =
- new TestBubbleDelegateView(anchor_widget->GetContentsView());
- Widget* bubble_widget = BubbleDelegateView::CreateBubble(bubble_delegate);
- bubble_widget->Show();
- BubbleFrameView* frame_view = bubble_delegate->GetBubbleFrameViewForTest();
- LabelButton* close_button = frame_view->close_;
- ASSERT_TRUE(close_button);
- frame_view->ButtonPressed(
- close_button,
- ui::MouseEvent(ui::ET_MOUSE_PRESSED, gfx::Point(0, 0), gfx::Point(0, 0),
- ui::EventTimeForNow(), ui::EF_NONE, ui::EF_NONE));
- EXPECT_TRUE(bubble_widget->IsClosed());
- EXPECT_EQ(BubbleDelegateView::CloseReason::CLOSE_BUTTON,
- bubble_delegate->close_reason());
- }
-}
-
} // namespace views
« no previous file with comments | « ui/views/bubble/bubble_delegate.cc ('k') | ui/views/bubble/bubble_frame_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698