chrome/browser/extensions/settings_api_bubble_delegate.cc - Issue 1456213002: Revert of [Extensions] Don't count bubble dismissal from focus loss as acknowledgment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/settings_api_bubble_delegate.cc

Issue 1456213002: Revert of [Extensions] Don't count bubble dismissal from focus loss as acknowledgment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/settings_api_bubble_delegate.h ('k') | chrome/browser/extensions/suspicious_extension_bubble_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/settings_api_bubble_delegate.cc

diff --git a/chrome/browser/extensions/settings_api_bubble_delegate.cc b/chrome/browser/extensions/settings_api_bubble_delegate.cc

index 26ac3da9c199b836e15b45a1de0f773173e857c1..2641883f200e1361a2539f2831b7068aaf5595df 100644

--- a/chrome/browser/extensions/settings_api_bubble_delegate.cc

+++ b/chrome/browser/extensions/settings_api_bubble_delegate.cc

@@ -238,17 +238,4 @@

}

-const char* SettingsApiBubbleDelegate::GetKey() {

- switch (type_) {

- case BUBBLE_TYPE_HOME_PAGE:

- return "SettingsApiBubbleDelegate.HomePage";

- case BUBBLE_TYPE_STARTUP_PAGES:

- return "SettingsApiBubbleDelegate.StartupPages";

- case BUBBLE_TYPE_SEARCH_ENGINE:

- return "SettingsApiBubbleDelegate.SearchEngine";

- }

- NOTREACHED();

- return "";

} // namespace extensions