Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1448873002: Generate list of GPU contexts outside tests (Closed)

Created:
5 years, 1 month ago by Kimmo Kinnunen
Modified:
5 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@commandbuffer-as-api-01-gpu-test-context-support
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Generate list of GPU contexts outside tests Use DEF_GPUTEST_FOR_*_CONTEXT macros to obtain the test GPU context. Makes changing the context -related classes easier, since not all tests need to be changed. BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/1530283c483cb88aa725bce50a6d193dd00ee570

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase, remove a hunk #

Total comments: 2

Patch Set 5 : make blurtest for all rendering contexts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+790 lines, -1090 lines) Patch
M tests/BlurTest.cpp View 1 2 3 4 6 chunks +5 lines, -19 lines 0 comments Download
M tests/ClipBoundsTest.cpp View 2 chunks +2 lines, -18 lines 0 comments Download
M tests/FloatingPointTextureTest.cpp View 3 chunks +22 lines, -37 lines 0 comments Download
M tests/GpuColorFilterTest.cpp View 4 chunks +2 lines, -16 lines 0 comments Download
M tests/GpuDrawPathTest.cpp View 1 2 3 4 3 chunks +9 lines, -29 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 3 chunks +170 lines, -185 lines 0 comments Download
M tests/GrDrawTargetTest.cpp View 1 chunk +3 lines, -17 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 2 3 4 4 chunks +7 lines, -15 lines 0 comments Download
M tests/GrSurfaceTest.cpp View 2 chunks +44 lines, -48 lines 0 comments Download
M tests/GrTextureMipMapInvalidationTest.cpp View 2 chunks +38 lines, -42 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 3 4 5 chunks +5 lines, -21 lines 0 comments Download
M tests/ImageIsOpaqueTest.cpp View 2 chunks +10 lines, -24 lines 0 comments Download
M tests/ImageNewShaderTest.cpp View 2 chunks +12 lines, -26 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 2 chunks +48 lines, -65 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 6 chunks +181 lines, -183 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 chunk +57 lines, -68 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 2 chunks +4 lines, -15 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 4 chunks +14 lines, -27 lines 0 comments Download
M tests/SRGBReadWritePixelsTest.cpp View 3 chunks +69 lines, -79 lines 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M tests/TextBlobCacheTest.cpp View 3 chunks +16 lines, -19 lines 0 comments Download
M tests/WritePixelsTest.cpp View 1 2 3 6 chunks +70 lines, -127 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Kimmo Kinnunen
5 years, 1 month ago (2015-11-16 10:52:20 UTC) #2
Kimmo Kinnunen
Brian, if you're up for the boring reviews again, this would be the next related ...
5 years ago (2015-11-24 15:44:45 UTC) #3
bsalomon
lgtm https://codereview.chromium.org/1448873002/diff/60001/tests/BlurTest.cpp File tests/BlurTest.cpp (right): https://codereview.chromium.org/1448873002/diff/60001/tests/BlurTest.cpp#newcode322 tests/BlurTest.cpp:322: DEF_GPUTEST_FOR_NATIVE_CONTEXT(BlurSigmaRange, reporter, context) { Might as well make ...
5 years ago (2015-11-30 15:35:35 UTC) #4
Kimmo Kinnunen
https://codereview.chromium.org/1448873002/diff/60001/tests/BlurTest.cpp File tests/BlurTest.cpp (right): https://codereview.chromium.org/1448873002/diff/60001/tests/BlurTest.cpp#newcode322 tests/BlurTest.cpp:322: DEF_GPUTEST_FOR_NATIVE_CONTEXT(BlurSigmaRange, reporter, context) { On 2015/11/30 15:35:35, bsalomon wrote: ...
5 years ago (2015-12-01 06:57:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448873002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448873002/80001
5 years ago (2015-12-01 06:57:37 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-01 12:35:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/1530283c483cb88aa725bce50a6d193dd00ee570

Powered by Google App Engine
This is Rietveld 408576698