Issue 144023009: Get rid of the unused native code StringAddStub.

Issue 144023009: Get rid of the unused native code StringAddStub. (Closed)

Created:
6 years, 11 months ago by Benedikt Meurer

Modified:
6 years, 11 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Get rid of the unused native code StringAddStub. BUG=v8:2990 LOG=n R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18752

Patch Set 3 : Remove obsolete StringHelper methods. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -2410 lines)			Patch
M	src/arm/code-stubs-arm.h	View	1 2	3 chunks	+0 lines, -55 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1 2	4 chunks	+1 line, -524 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View		1 chunk	+5 lines, -14 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+5 lines, -12 lines	0 comments	Download
M	src/code-stubs.h	View	1	4 chunks	+16 lines, -19 lines	0 comments	Download
M	src/code-stubs.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View	1 2	3 chunks	+0 lines, -53 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 2	3 chunks	+1 line, -513 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		1 chunk	+5 lines, -14 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+5 lines, -12 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/isolate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/code-stubs-mips.h	View	1 2	3 chunks	+0 lines, -55 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1 2	4 chunks	+1 line, -516 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View		1 chunk	+6 lines, -14 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+5 lines, -12 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/x64/code-stubs-x64.h	View	1 2	3 chunks	+0 lines, -48 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 2	3 chunks	+1 line, -487 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View		1 chunk	+5 lines, -14 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+5 lines, -12 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Hey Hannes, Here's the CL to finally get rid of the native code for StringAddStub ...

6 years, 11 months ago (2014-01-22 13:00:20 UTC) #1

Hannes Payer (out of office)

LGTM, 1 nit https://codereview.chromium.org/144023009/diff/1/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/144023009/diff/1/src/code-stubs.h#newcode47 src/code-stubs.h:47: V(NewStringAdd) \ StringAdd?

6 years, 11 months ago (2014-01-22 13:05:57 UTC) #2

Benedikt Meurer

https://codereview.chromium.org/144023009/diff/1/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/144023009/diff/1/src/code-stubs.h#newcode47 src/code-stubs.h:47: V(NewStringAdd) \ On 2014/01/22 13:05:57, Hannes Payer wrote: > ...

6 years, 11 months ago (2014-01-22 13:16:02 UTC) #3

Benedikt Meurer

6 years, 11 months ago (2014-01-22 13:48:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r18752 (presubmit successful).

Expand Messages | Collapse Messages