Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 144023009: Get rid of the unused native code StringAddStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove obsolete StringHelper methods. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2210 matching lines...) Expand 10 before | Expand all | Expand 10 after
2221 LOperand* value = UseFixed(instr->value(), rax); 2221 LOperand* value = UseFixed(instr->value(), rax);
2222 2222
2223 LStoreNamedGeneric* result = 2223 LStoreNamedGeneric* result =
2224 new(zone()) LStoreNamedGeneric(context, object, value); 2224 new(zone()) LStoreNamedGeneric(context, object, value);
2225 return MarkAsCall(result, instr); 2225 return MarkAsCall(result, instr);
2226 } 2226 }
2227 2227
2228 2228
2229 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) { 2229 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) {
2230 LOperand* context = UseFixed(instr->context(), rsi); 2230 LOperand* context = UseFixed(instr->context(), rsi);
2231 LOperand* left = FLAG_new_string_add 2231 LOperand* left = UseFixed(instr->left(), rdx);
2232 ? UseFixed(instr->left(), rdx) 2232 LOperand* right = UseFixed(instr->right(), rax);
2233 : UseOrConstantAtStart(instr->left());
2234 LOperand* right = FLAG_new_string_add
2235 ? UseFixed(instr->right(), rax)
2236 : UseOrConstantAtStart(instr->right());
2237 return MarkAsCall( 2233 return MarkAsCall(
2238 DefineFixed(new(zone()) LStringAdd(context, left, right), rax), instr); 2234 DefineFixed(new(zone()) LStringAdd(context, left, right), rax), instr);
2239 } 2235 }
2240 2236
2241 2237
2242 LInstruction* LChunkBuilder::DoStringCharCodeAt(HStringCharCodeAt* instr) { 2238 LInstruction* LChunkBuilder::DoStringCharCodeAt(HStringCharCodeAt* instr) {
2243 LOperand* string = UseTempRegister(instr->string()); 2239 LOperand* string = UseTempRegister(instr->string());
2244 LOperand* index = UseTempRegister(instr->index()); 2240 LOperand* index = UseTempRegister(instr->index());
2245 LOperand* context = UseAny(instr->context()); 2241 LOperand* context = UseAny(instr->context());
2246 LStringCharCodeAt* result = 2242 LStringCharCodeAt* result =
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
2493 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2489 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2494 LOperand* object = UseRegister(instr->object()); 2490 LOperand* object = UseRegister(instr->object());
2495 LOperand* index = UseTempRegister(instr->index()); 2491 LOperand* index = UseTempRegister(instr->index());
2496 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2492 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2497 } 2493 }
2498 2494
2499 2495
2500 } } // namespace v8::internal 2496 } } // namespace v8::internal
2501 2497
2502 #endif // V8_TARGET_ARCH_X64 2498 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698