Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 144023009: Get rid of the unused native code StringAddStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove obsolete StringHelper methods. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/code-stubs.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4490 matching lines...) Expand 10 before | Expand all | Expand 10 after
4501 Register temp = ToRegister(instr->temp()); 4501 Register temp = ToRegister(instr->temp());
4502 Label no_memento_found; 4502 Label no_memento_found;
4503 __ TestJSArrayForAllocationMemento(object, temp, &no_memento_found); 4503 __ TestJSArrayForAllocationMemento(object, temp, &no_memento_found);
4504 DeoptimizeIf(eq, instr->environment()); 4504 DeoptimizeIf(eq, instr->environment());
4505 __ bind(&no_memento_found); 4505 __ bind(&no_memento_found);
4506 } 4506 }
4507 4507
4508 4508
4509 void LCodeGen::DoStringAdd(LStringAdd* instr) { 4509 void LCodeGen::DoStringAdd(LStringAdd* instr) {
4510 ASSERT(ToRegister(instr->context()).is(cp)); 4510 ASSERT(ToRegister(instr->context()).is(cp));
4511 if (FLAG_new_string_add) { 4511 ASSERT(ToRegister(instr->left()).is(r1));
4512 ASSERT(ToRegister(instr->left()).is(r1)); 4512 ASSERT(ToRegister(instr->right()).is(r0));
4513 ASSERT(ToRegister(instr->right()).is(r0)); 4513 StringAddStub stub(instr->hydrogen()->flags(),
4514 NewStringAddStub stub(instr->hydrogen()->flags(), 4514 isolate()->heap()->GetPretenureMode());
4515 isolate()->heap()->GetPretenureMode()); 4515 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
4516 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
4517 } else {
4518 __ push(ToRegister(instr->left()));
4519 __ push(ToRegister(instr->right()));
4520 StringAddStub stub(instr->hydrogen()->flags());
4521 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
4522 }
4523 } 4516 }
4524 4517
4525 4518
4526 void LCodeGen::DoStringCharCodeAt(LStringCharCodeAt* instr) { 4519 void LCodeGen::DoStringCharCodeAt(LStringCharCodeAt* instr) {
4527 class DeferredStringCharCodeAt V8_FINAL : public LDeferredCode { 4520 class DeferredStringCharCodeAt V8_FINAL : public LDeferredCode {
4528 public: 4521 public:
4529 DeferredStringCharCodeAt(LCodeGen* codegen, LStringCharCodeAt* instr) 4522 DeferredStringCharCodeAt(LCodeGen* codegen, LStringCharCodeAt* instr)
4530 : LDeferredCode(codegen), instr_(instr) { } 4523 : LDeferredCode(codegen), instr_(instr) { }
4531 virtual void Generate() V8_OVERRIDE { 4524 virtual void Generate() V8_OVERRIDE {
4532 codegen()->DoDeferredStringCharCodeAt(instr_); 4525 codegen()->DoDeferredStringCharCodeAt(instr_);
(...skipping 1298 matching lines...) Expand 10 before | Expand all | Expand 10 after
5831 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index)); 5824 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index));
5832 __ ldr(result, FieldMemOperand(scratch, 5825 __ ldr(result, FieldMemOperand(scratch,
5833 FixedArray::kHeaderSize - kPointerSize)); 5826 FixedArray::kHeaderSize - kPointerSize));
5834 __ bind(&done); 5827 __ bind(&done);
5835 } 5828 }
5836 5829
5837 5830
5838 #undef __ 5831 #undef __
5839 5832
5840 } } // namespace v8::internal 5833 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698