Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 144023009: Get rid of the unused native code StringAddStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove obsolete StringHelper methods. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3712 matching lines...) Expand 10 before | Expand all | Expand 10 after
3723 generator.GenerateSlow(masm_, call_helper); 3723 generator.GenerateSlow(masm_, call_helper);
3724 3724
3725 __ bind(&done); 3725 __ bind(&done);
3726 context()->Plug(result); 3726 context()->Plug(result);
3727 } 3727 }
3728 3728
3729 3729
3730 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) { 3730 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
3731 ZoneList<Expression*>* args = expr->arguments(); 3731 ZoneList<Expression*>* args = expr->arguments();
3732 ASSERT_EQ(2, args->length()); 3732 ASSERT_EQ(2, args->length());
3733 if (FLAG_new_string_add) { 3733 VisitForStackValue(args->at(0));
3734 VisitForStackValue(args->at(0)); 3734 VisitForAccumulatorValue(args->at(1));
3735 VisitForAccumulatorValue(args->at(1));
3736 3735
3737 __ pop(a1); 3736 __ pop(a1);
3738 __ mov(a0, result_register()); // NewStringAddStub requires args in a0, a1. 3737 __ mov(a0, result_register()); // StringAddStub requires args in a0, a1.
3739 NewStringAddStub stub(STRING_ADD_CHECK_BOTH, NOT_TENURED); 3738 StringAddStub stub(STRING_ADD_CHECK_BOTH, NOT_TENURED);
3740 __ CallStub(&stub); 3739 __ CallStub(&stub);
3741 } else {
3742 VisitForStackValue(args->at(0));
3743 VisitForStackValue(args->at(1));
3744
3745 StringAddStub stub(STRING_ADD_CHECK_BOTH);
3746 __ CallStub(&stub);
3747 }
3748 context()->Plug(v0); 3740 context()->Plug(v0);
3749 } 3741 }
3750 3742
3751 3743
3752 void FullCodeGenerator::EmitStringCompare(CallRuntime* expr) { 3744 void FullCodeGenerator::EmitStringCompare(CallRuntime* expr) {
3753 ZoneList<Expression*>* args = expr->arguments(); 3745 ZoneList<Expression*>* args = expr->arguments();
3754 ASSERT_EQ(2, args->length()); 3746 ASSERT_EQ(2, args->length());
3755 3747
3756 VisitForStackValue(args->at(0)); 3748 VisitForStackValue(args->at(0));
3757 VisitForStackValue(args->at(1)); 3749 VisitForStackValue(args->at(1));
(...skipping 1209 matching lines...) Expand 10 before | Expand all | Expand 10 after
4967 Assembler::target_address_at(pc_immediate_load_address)) == 4959 Assembler::target_address_at(pc_immediate_load_address)) ==
4968 reinterpret_cast<uint32_t>( 4960 reinterpret_cast<uint32_t>(
4969 isolate->builtins()->OsrAfterStackCheck()->entry())); 4961 isolate->builtins()->OsrAfterStackCheck()->entry()));
4970 return OSR_AFTER_STACK_CHECK; 4962 return OSR_AFTER_STACK_CHECK;
4971 } 4963 }
4972 4964
4973 4965
4974 } } // namespace v8::internal 4966 } } // namespace v8::internal
4975 4967
4976 #endif // V8_TARGET_ARCH_MIPS 4968 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698