Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 144023009: Get rid of the unused native code StringAddStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove obsolete StringHelper methods. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2360 matching lines...) Expand 10 before | Expand all | Expand 10 after
2371 LOperand* value = UseFixed(instr->value(), eax); 2371 LOperand* value = UseFixed(instr->value(), eax);
2372 2372
2373 LStoreNamedGeneric* result = 2373 LStoreNamedGeneric* result =
2374 new(zone()) LStoreNamedGeneric(context, object, value); 2374 new(zone()) LStoreNamedGeneric(context, object, value);
2375 return MarkAsCall(result, instr); 2375 return MarkAsCall(result, instr);
2376 } 2376 }
2377 2377
2378 2378
2379 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) { 2379 LInstruction* LChunkBuilder::DoStringAdd(HStringAdd* instr) {
2380 LOperand* context = UseFixed(instr->context(), esi); 2380 LOperand* context = UseFixed(instr->context(), esi);
2381 LOperand* left = FLAG_new_string_add 2381 LOperand* left = UseFixed(instr->left(), edx);
2382 ? UseFixed(instr->left(), edx) 2382 LOperand* right = UseFixed(instr->right(), eax);
2383 : UseOrConstantAtStart(instr->left());
2384 LOperand* right = FLAG_new_string_add
2385 ? UseFixed(instr->right(), eax)
2386 : UseOrConstantAtStart(instr->right());
2387 LStringAdd* string_add = new(zone()) LStringAdd(context, left, right); 2383 LStringAdd* string_add = new(zone()) LStringAdd(context, left, right);
2388 return MarkAsCall(DefineFixed(string_add, eax), instr); 2384 return MarkAsCall(DefineFixed(string_add, eax), instr);
2389 } 2385 }
2390 2386
2391 2387
2392 LInstruction* LChunkBuilder::DoStringCharCodeAt(HStringCharCodeAt* instr) { 2388 LInstruction* LChunkBuilder::DoStringCharCodeAt(HStringCharCodeAt* instr) {
2393 LOperand* string = UseTempRegister(instr->string()); 2389 LOperand* string = UseTempRegister(instr->string());
2394 LOperand* index = UseTempRegister(instr->index()); 2390 LOperand* index = UseTempRegister(instr->index());
2395 LOperand* context = UseAny(instr->context()); 2391 LOperand* context = UseAny(instr->context());
2396 LStringCharCodeAt* result = 2392 LStringCharCodeAt* result =
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
2647 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2643 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2648 LOperand* object = UseRegister(instr->object()); 2644 LOperand* object = UseRegister(instr->object());
2649 LOperand* index = UseTempRegister(instr->index()); 2645 LOperand* index = UseTempRegister(instr->index());
2650 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2646 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2651 } 2647 }
2652 2648
2653 2649
2654 } } // namespace v8::internal 2650 } } // namespace v8::internal
2655 2651
2656 #endif // V8_TARGET_ARCH_IA32 2652 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698