Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 144023009: Get rid of the unused native code StringAddStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove obsolete StringHelper methods. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/lithium-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3656 matching lines...) Expand 10 before | Expand all | Expand 10 after
3667 generator.GenerateSlow(masm_, call_helper); 3667 generator.GenerateSlow(masm_, call_helper);
3668 3668
3669 __ bind(&done); 3669 __ bind(&done);
3670 context()->Plug(result); 3670 context()->Plug(result);
3671 } 3671 }
3672 3672
3673 3673
3674 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) { 3674 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
3675 ZoneList<Expression*>* args = expr->arguments(); 3675 ZoneList<Expression*>* args = expr->arguments();
3676 ASSERT_EQ(2, args->length()); 3676 ASSERT_EQ(2, args->length());
3677 VisitForStackValue(args->at(0));
3678 VisitForAccumulatorValue(args->at(1));
3677 3679
3678 if (FLAG_new_string_add) { 3680 __ pop(r1);
3679 VisitForStackValue(args->at(0)); 3681 StringAddStub stub(STRING_ADD_CHECK_BOTH, NOT_TENURED);
3680 VisitForAccumulatorValue(args->at(1)); 3682 __ CallStub(&stub);
3681
3682 __ pop(r1);
3683 NewStringAddStub stub(STRING_ADD_CHECK_BOTH, NOT_TENURED);
3684 __ CallStub(&stub);
3685 } else {
3686 VisitForStackValue(args->at(0));
3687 VisitForStackValue(args->at(1));
3688
3689 StringAddStub stub(STRING_ADD_CHECK_BOTH);
3690 __ CallStub(&stub);
3691 }
3692 context()->Plug(r0); 3683 context()->Plug(r0);
3693 } 3684 }
3694 3685
3695 3686
3696 void FullCodeGenerator::EmitStringCompare(CallRuntime* expr) { 3687 void FullCodeGenerator::EmitStringCompare(CallRuntime* expr) {
3697 ZoneList<Expression*>* args = expr->arguments(); 3688 ZoneList<Expression*>* args = expr->arguments();
3698 ASSERT_EQ(2, args->length()); 3689 ASSERT_EQ(2, args->length());
3699 VisitForStackValue(args->at(0)); 3690 VisitForStackValue(args->at(0));
3700 VisitForStackValue(args->at(1)); 3691 VisitForStackValue(args->at(1));
3701 3692
(...skipping 1210 matching lines...) Expand 10 before | Expand all | Expand 10 after
4912 ASSERT(Memory::uint32_at(interrupt_address_pointer) == 4903 ASSERT(Memory::uint32_at(interrupt_address_pointer) ==
4913 reinterpret_cast<uint32_t>( 4904 reinterpret_cast<uint32_t>(
4914 isolate->builtins()->OsrAfterStackCheck()->entry())); 4905 isolate->builtins()->OsrAfterStackCheck()->entry()));
4915 return OSR_AFTER_STACK_CHECK; 4906 return OSR_AFTER_STACK_CHECK;
4916 } 4907 }
4917 4908
4918 4909
4919 } } // namespace v8::internal 4910 } } // namespace v8::internal
4920 4911
4921 #endif // V8_TARGET_ARCH_ARM 4912 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/lithium-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698