Oilpan: move InspectedFrames to the heap.

Oilpan: move InspectedFrames to the heap.

R=haraken
BUG=553613
Committed: https://crrev.com/48a12b9510ea0159c0a85da37f177f41547ad33a
Cr-Commit-Position: refs/heads/master@{#359811}

[sof, 2015-11-12 19:59:32]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[haraken, 2015-11-13 11:45:23]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-11-13 11:45:23]

https://codereview.chromium.org/1434383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectedFrames.h (right):

https://codereview.chromium.org/1434383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectedFrames.h:17: class CORE_EXPORT
InspectedFrames {

There are only 3 places that instantiate an InspectedFrames. Maybe is it easy to
move this to the heap?

[sof, 2015-11-16 06:26:42]

Description was changed from

==========
Oilpan: tidy up InspectedFrames' LocalFrame handling.

R=
BUG=553613
==========

to

==========
Oilpan: move InspectedFrames to the heap.

R=
BUG=553613
==========

[sof, 2015-11-16 06:27:32]

https://codereview.chromium.org/1434383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectedFrames.h (right):

https://codereview.chromium.org/1434383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectedFrames.h:17: class CORE_EXPORT
InspectedFrames {
On 2015/11/13 11:45:23, haraken wrote:
> 
> There are only 3 places that instantiate an InspectedFrames. Maybe is it easy
to
> move this to the heap?

Referenced to in a bunch of places though, but now done.

[haraken, 2015-11-16 06:39:36]

On 2015/11/16 06:27:32, sof wrote:
>
https://codereview.chromium.org/1434383002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/inspector/InspectedFrames.h (right):
> 
>
https://codereview.chromium.org/1434383002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/inspector/InspectedFrames.h:17: class
CORE_EXPORT
> InspectedFrames {
> On 2015/11/13 11:45:23, haraken wrote:
> > 
> > There are only 3 places that instantiate an InspectedFrames. Maybe is it
easy
> to
> > move this to the heap?
> 
> Referenced to in a bunch of places though, but now done.

Thanks, LGTM!

[sof, 2015-11-16 06:43:15]

Description was changed from

==========
Oilpan: move InspectedFrames to the heap.

R=
BUG=553613
==========

to

==========
Oilpan: move InspectedFrames to the heap.

R=haraken
BUG=553613
==========

[sof, 2015-11-16 06:43:25]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-11-16 06:43:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1434383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1434383002/20001

[commit-bot: I haz the power, 2015-11-16 06:51:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-16 06:51:50]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sof, 2015-11-16 09:03:45]

https://codereview.chromium.org/1434383002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h
(right):

https://codereview.chromium.org/1434383002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h:77:
OwnPtrWillBeMember<InspectedFrames> m_inspectedFrames;
This should be RawPtrWillBeMember<>; fixed in ps#3.

[sof, 2015-11-16 09:03:49]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-11-16 09:03:49]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1434383002/#ps40001
(title: "fix incorrect OwnPtr<> use")

[commit-bot: I haz the power, 2015-11-16 09:04:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1434383002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1434383002/40001

[commit-bot: I haz the power, 2015-11-16 10:07:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-16 10:08:14]

Patchset 3 (id:??) landed as
https://crrev.com/48a12b9510ea0159c0a85da37f177f41547ad33a
Cr-Commit-Position: refs/heads/master@{#359811}