third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp - Issue 1434383002: Oilpan: move InspectedFrames to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp

Issue 1434383002: Oilpan: move InspectedFrames to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix incorrect OwnPtr<> use Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp

diff --git a/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp b/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp

index 4c0eb81dfa4ab55f8a534ca4cf2f578eb2c4bacc..8da4193cb8802279336433f1cf6dd11a1cc9d678 100644

--- a/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp

+++ b/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp

@@ -210,7 +210,8 @@ StorageArea* InspectorDOMStorageAgent::findStorageArea(ErrorString* errorString,

if (!m_page->mainFrame()->isLocalFrame())

return nullptr;

- LocalFrame* frame = InspectedFrames(m_page->deprecatedLocalMainFrame()).frameWithSecurityOrigin(securityOrigin);

+ OwnPtrWillBeRawPtr<InspectedFrames> inspectedFrames = InspectedFrames::create(m_page->deprecatedLocalMainFrame());

+ LocalFrame* frame = inspectedFrames->frameWithSecurityOrigin(securityOrigin);

if (!frame) {

if (errorString)

*errorString = "LocalFrame not found for the given security origin";