third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h - Issue 1434383002: Oilpan: move InspectedFrames to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h

Issue 1434383002: Oilpan: move InspectedFrames to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix incorrect OwnPtr<> use Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h b/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h

index 2d47b595cf09c2d7b615f3b2a8be3554f5200014..edc1fdbe85514d5976677e837e39377614a0d80f 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h

@@ -66,14 +66,15 @@ public:

void getApplicationCacheForFrame(ErrorString*, const String& frameId, RefPtr<TypeBuilder::ApplicationCache::ApplicationCache>&) override;

private:

- InspectorApplicationCacheAgent(InspectedFrames*);

+ explicit InspectorApplicationCacheAgent(InspectedFrames*);

PassRefPtr<TypeBuilder::ApplicationCache::ApplicationCache> buildObjectForApplicationCache(const ApplicationCacheHost::ResourceInfoList&, const ApplicationCacheHost::CacheInfo&);

PassRefPtr<TypeBuilder::Array<TypeBuilder::ApplicationCache::ApplicationCacheResource> > buildArrayForApplicationCacheResources(const ApplicationCacheHost::ResourceInfoList&);

PassRefPtr<TypeBuilder::ApplicationCache::ApplicationCacheResource> buildObjectForApplicationCacheResource(const ApplicationCacheHost::ResourceInfo&);

DocumentLoader* assertFrameWithDocumentLoader(ErrorString*, String frameId);

- InspectedFrames* m_inspectedFrames;

+ RawPtrWillBeMember<InspectedFrames> m_inspectedFrames;

};

} // namespace blink