third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp - Issue 1434383002: Oilpan: move InspectedFrames to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp

Issue 1434383002: Oilpan: move InspectedFrames to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix incorrect OwnPtr<> use Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp b/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp

index 5ce3fd9a73b8d4ca7bd8c4dce209cf5151d852e4..0a308187fab5c8b9650b7467865d89105435e866 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp

@@ -93,7 +93,8 @@ void InspectorResourceContentLoader::start()

{

m_started = true;

WillBeHeapVector<RawPtrWillBeMember<Document>> documents;

- for (LocalFrame* frame : InspectedFrames(m_inspectedFrame)) {

+ OwnPtrWillBeRawPtr<InspectedFrames> inspectedFrames = InspectedFrames::create(m_inspectedFrame);

+ for (LocalFrame* frame : *inspectedFrames) {

documents.append(frame->document());

documents.appendVector(InspectorPageAgent::importsForFrame(frame));

}