third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp - Issue 1434383002: Oilpan: move InspectedFrames to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 1434383002: Oilpan: move InspectedFrames to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix incorrect OwnPtr<> use Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

index 62258a2b8710f2eaec185c10294079bebbc3a564..e21c267768afe49f85044c339b9f566abff03056 100644

--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

@@ -320,7 +320,7 @@ WebDevToolsAgentImpl::WebDevToolsAgentImpl(

, m_resourceContentLoader(InspectorResourceContentLoader::create(m_webLocalFrameImpl->frame()))

, m_state(adoptPtrWillBeNoop(new InspectorCompositeState(this)))

, m_overlay(overlay)

- , m_inspectedFrames(adoptPtr(new InspectedFrames(m_webLocalFrameImpl->frame())))

+ , m_inspectedFrames(InspectedFrames::create(m_webLocalFrameImpl->frame()))

, m_inspectorAgent(nullptr)

, m_domAgent(nullptr)

, m_pageAgent(nullptr)

@@ -413,6 +413,7 @@ DEFINE_TRACE(WebDevToolsAgentImpl)

visitor->trace(m_resourceContentLoader);

visitor->trace(m_state);

visitor->trace(m_overlay);

+ visitor->trace(m_inspectedFrames);

visitor->trace(m_inspectorAgent);

visitor->trace(m_domAgent);

visitor->trace(m_pageAgent);

« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »