Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 1434383002: Oilpan: move InspectedFrames to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix incorrect OwnPtr<> use Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 , m_webLocalFrameImpl(webLocalFrameImpl) 313 , m_webLocalFrameImpl(webLocalFrameImpl)
314 , m_attached(false) 314 , m_attached(false)
315 #if ENABLE(ASSERT) 315 #if ENABLE(ASSERT)
316 , m_hasBeenDisposed(false) 316 , m_hasBeenDisposed(false)
317 #endif 317 #endif
318 , m_instrumentingAgents(m_webLocalFrameImpl->frame()->instrumentingAgents()) 318 , m_instrumentingAgents(m_webLocalFrameImpl->frame()->instrumentingAgents())
319 , m_injectedScriptManager(InjectedScriptManager::createForPage()) 319 , m_injectedScriptManager(InjectedScriptManager::createForPage())
320 , m_resourceContentLoader(InspectorResourceContentLoader::create(m_webLocalF rameImpl->frame())) 320 , m_resourceContentLoader(InspectorResourceContentLoader::create(m_webLocalF rameImpl->frame()))
321 , m_state(adoptPtrWillBeNoop(new InspectorCompositeState(this))) 321 , m_state(adoptPtrWillBeNoop(new InspectorCompositeState(this)))
322 , m_overlay(overlay) 322 , m_overlay(overlay)
323 , m_inspectedFrames(adoptPtr(new InspectedFrames(m_webLocalFrameImpl->frame( )))) 323 , m_inspectedFrames(InspectedFrames::create(m_webLocalFrameImpl->frame()))
324 , m_inspectorAgent(nullptr) 324 , m_inspectorAgent(nullptr)
325 , m_domAgent(nullptr) 325 , m_domAgent(nullptr)
326 , m_pageAgent(nullptr) 326 , m_pageAgent(nullptr)
327 , m_resourceAgent(nullptr) 327 , m_resourceAgent(nullptr)
328 , m_layerTreeAgent(nullptr) 328 , m_layerTreeAgent(nullptr)
329 , m_tracingAgent(nullptr) 329 , m_tracingAgent(nullptr)
330 , m_pageRuntimeAgent(nullptr) 330 , m_pageRuntimeAgent(nullptr)
331 , m_pageConsoleAgent(nullptr) 331 , m_pageConsoleAgent(nullptr)
332 , m_agents(m_instrumentingAgents.get(), m_state.get()) 332 , m_agents(m_instrumentingAgents.get(), m_state.get())
333 , m_deferredAgentsInitialized(false) 333 , m_deferredAgentsInitialized(false)
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 } 406 }
407 407
408 DEFINE_TRACE(WebDevToolsAgentImpl) 408 DEFINE_TRACE(WebDevToolsAgentImpl)
409 { 409 {
410 visitor->trace(m_webLocalFrameImpl); 410 visitor->trace(m_webLocalFrameImpl);
411 visitor->trace(m_instrumentingAgents); 411 visitor->trace(m_instrumentingAgents);
412 visitor->trace(m_injectedScriptManager); 412 visitor->trace(m_injectedScriptManager);
413 visitor->trace(m_resourceContentLoader); 413 visitor->trace(m_resourceContentLoader);
414 visitor->trace(m_state); 414 visitor->trace(m_state);
415 visitor->trace(m_overlay); 415 visitor->trace(m_overlay);
416 visitor->trace(m_inspectedFrames);
416 visitor->trace(m_inspectorAgent); 417 visitor->trace(m_inspectorAgent);
417 visitor->trace(m_domAgent); 418 visitor->trace(m_domAgent);
418 visitor->trace(m_pageAgent); 419 visitor->trace(m_pageAgent);
419 visitor->trace(m_resourceAgent); 420 visitor->trace(m_resourceAgent);
420 visitor->trace(m_layerTreeAgent); 421 visitor->trace(m_layerTreeAgent);
421 visitor->trace(m_tracingAgent); 422 visitor->trace(m_tracingAgent);
422 visitor->trace(m_pageRuntimeAgent); 423 visitor->trace(m_pageRuntimeAgent);
423 visitor->trace(m_pageConsoleAgent); 424 visitor->trace(m_pageConsoleAgent);
424 visitor->trace(m_inspectorBackendDispatcher); 425 visitor->trace(m_inspectorBackendDispatcher);
425 visitor->trace(m_agents); 426 visitor->trace(m_agents);
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
718 if (!InspectorBackendDispatcher::getCommandName(message, &commandName)) 719 if (!InspectorBackendDispatcher::getCommandName(message, &commandName))
719 return false; 720 return false;
720 return commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_pauseCmd) 721 return commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_pauseCmd)
721 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointCmd) 722 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointCmd)
722 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointByUrlCmd) 723 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointByUrlCmd)
723 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_removeBreakpointCmd) 724 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_removeBreakpointCmd)
724 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointsActiveCmd); 725 || commandName == InspectorBackendDispatcher::commandName(InspectorBacke ndDispatcher::kDebugger_setBreakpointsActiveCmd);
725 } 726 }
726 727
727 } // namespace blink 728 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698