Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1430713003: Add mul instruction to ARM integrated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add mul instruction to ARM integrated assembler. Also cleans up a couple of template definitions by using the appropriate "using" type name. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=396de5322ca78d9a2b313edec7f9d98ad66ad6b9

Patch Set 1 #

Patch Set 2 : Add i64 multiplication example. #

Total comments: 6

Patch Set 3 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -13 lines) Patch
M src/DartARM32/assembler_arm.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 2 2 chunks +10 lines, -2 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 2 4 chunks +41 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 2 2 chunks +11 lines, -8 lines 0 comments Download
A tests_lit/assembler/arm32/mul.ll View 1 2 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Karl
5 years, 1 month ago (2015-10-29 19:42:32 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1430713003/diff/20001/src/DartARM32/assembler_arm.h File src/DartARM32/assembler_arm.h (right): https://codereview.chromium.org/1430713003/diff/20001/src/DartARM32/assembler_arm.h#newcode501 src/DartARM32/assembler_arm.h:501: // Moved to moved to where? https://codereview.chromium.org/1430713003/diff/20001/src/IceAssemblerARM32.cpp File ...
5 years, 1 month ago (2015-10-29 22:17:58 UTC) #4
Karl
Committed patchset #3 (id:40001) manually as 396de5322ca78d9a2b313edec7f9d98ad66ad6b9 (presubmit successful).
5 years, 1 month ago (2015-10-30 14:25:48 UTC) #5
Karl
5 years, 1 month ago (2015-10-30 14:25:57 UTC) #6
Message was sent while issue was closed. 
https://chromiumcodereview.appspot.com/1430713003/diff/20001/src/DartARM32/as...
File src/DartARM32/assembler_arm.h (right):

https://chromiumcodereview.appspot.com/1430713003/diff/20001/src/DartARM32/as...
src/DartARM32/assembler_arm.h:501: // Moved to
On 2015/10/29 22:17:58, stichnot wrote:
> moved to where?

Added context.

https://chromiumcodereview.appspot.com/1430713003/diff/20001/src/IceAssembler...
File src/IceAssemblerARM32.cpp (right):

https://chromiumcodereview.appspot.com/1430713003/diff/20001/src/IceAssembler...
src/IceAssemblerARM32.cpp:649: IValueT MulOpcode = 0;
On 2015/10/29 22:17:58, stichnot wrote:
> constexpr?

Done.

https://chromiumcodereview.appspot.com/1430713003/diff/20001/tests_lit/assemb...
File tests_lit/assembler/arm32/mul.ll (right):

https://chromiumcodereview.appspot.com/1430713003/diff/20001/tests_lit/assemb...
tests_lit/assembler/arm32/mul.ll:82: 
On 2015/10/29 22:17:58, stichnot wrote:
> Remove trailing whitespace (blank lines) to keep git happy.

Done.

Powered by Google App Engine
This is Rietveld 408576698