Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417893006: sync compositor: pass simple gfx types by const ref (Closed)

Created:
5 years, 1 month ago by boliu
Modified:
5 years, 1 month ago
Reviewers:
no sievers
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sync compositor: pass simple gfx types by const ref See bug for reasoning BUG=159273 Committed: https://crrev.com/6d9425ec7badda912555d46ea7abcfab81fdd9b9 Cr-Commit-Position: refs/heads/master@{#356653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -69 lines) Patch
M android_webview/browser/browser_view_renderer.h View 2 chunks +5 lines, -5 lines 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M android_webview/browser/browser_view_renderer_client.h View 1 chunk +5 lines, -5 lines 0 comments Download
M android_webview/browser/test/rendering_test.h View 1 chunk +5 lines, -5 lines 0 comments Download
M android_webview/native/aw_contents.h View 1 chunk +5 lines, -5 lines 0 comments Download
M android_webview/native/aw_contents.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/public/browser/android/synchronous_compositor.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/public/browser/android/synchronous_compositor_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/test/test_synchronous_compositor_android.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/public/test/test_synchronous_compositor_android.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/android/synchronous_compositor_output_surface.h View 2 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/android/synchronous_compositor_output_surface.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
boliu
ptal easy review!
5 years, 1 month ago (2015-10-28 01:15:28 UTC) #3
no sievers
lgtm
5 years, 1 month ago (2015-10-28 20:33:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417893006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417893006/1
5 years, 1 month ago (2015-10-28 20:34:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 21:38:41 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 21:39:33 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6d9425ec7badda912555d46ea7abcfab81fdd9b9
Cr-Commit-Position: refs/heads/master@{#356653}

Powered by Google App Engine
This is Rietveld 408576698