Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: android_webview/native/aw_contents.cc

Issue 1417893006: sync compositor: pass simple gfx types by const ref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_contents.cc
diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc
index 6a46d1d925444337e4244832530895af26f4cffd..e10eab626137ea1752df3bcd80a91785437f7c94 100644
--- a/android_webview/native/aw_contents.cc
+++ b/android_webview/native/aw_contents.cc
@@ -1004,7 +1004,7 @@ gfx::Point AwContents::GetLocationOnScreen() {
return gfx::Point(location[0], location[1]);
}
-void AwContents::ScrollContainerViewTo(gfx::Vector2d new_value) {
+void AwContents::ScrollContainerViewTo(const gfx::Vector2d& new_value) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
@@ -1014,8 +1014,8 @@ void AwContents::ScrollContainerViewTo(gfx::Vector2d new_value) {
env, obj.obj(), new_value.x(), new_value.y());
}
-void AwContents::UpdateScrollState(gfx::Vector2d max_scroll_offset,
- gfx::SizeF contents_size_dip,
+void AwContents::UpdateScrollState(const gfx::Vector2d& max_scroll_offset,
+ const gfx::SizeF& contents_size_dip,
float page_scale_factor,
float min_page_scale_factor,
float max_page_scale_factor) {
@@ -1035,8 +1035,8 @@ void AwContents::UpdateScrollState(gfx::Vector2d max_scroll_offset,
max_page_scale_factor);
}
-void AwContents::DidOverscroll(gfx::Vector2d overscroll_delta,
- gfx::Vector2dF overscroll_velocity) {
+void AwContents::DidOverscroll(const gfx::Vector2d& overscroll_delta,
+ const gfx::Vector2dF& overscroll_velocity) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
« no previous file with comments | « android_webview/native/aw_contents.h ('k') | content/browser/android/in_process/synchronous_compositor_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698