Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2002)

Unified Diff: android_webview/browser/browser_view_renderer.h

Issue 1417893006: sync compositor: pass simple gfx types by const ref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/browser/browser_view_renderer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/browser_view_renderer.h
diff --git a/android_webview/browser/browser_view_renderer.h b/android_webview/browser/browser_view_renderer.h
index b4205c520f7a230e0c822a0f366a387a6636c426..21c28c8f97da3ef4ad14aef6cfa08917f44ece72 100644
--- a/android_webview/browser/browser_view_renderer.h
+++ b/android_webview/browser/browser_view_renderer.h
@@ -84,7 +84,7 @@ class BrowserViewRenderer : public content::SynchronousCompositorClient {
float page_scale_factor() const { return page_scale_factor_; }
// Set the root layer scroll offset to |new_value|.
- void ScrollTo(gfx::Vector2d new_value);
+ void ScrollTo(const gfx::Vector2d& new_value);
// Android views hierarchy gluing.
bool IsVisible() const;
@@ -110,15 +110,15 @@ class BrowserViewRenderer : public content::SynchronousCompositorClient {
float page_scale_factor,
float min_page_scale_factor,
float max_page_scale_factor) override;
- void DidOverscroll(gfx::Vector2dF accumulated_overscroll,
- gfx::Vector2dF latest_overscroll_delta,
- gfx::Vector2dF current_fling_velocity) override;
+ void DidOverscroll(const gfx::Vector2dF& accumulated_overscroll,
+ const gfx::Vector2dF& latest_overscroll_delta,
+ const gfx::Vector2dF& current_fling_velocity) override;
void UpdateParentDrawConstraints();
void DetachFunctorFromView();
private:
- void SetTotalRootLayerScrollOffset(gfx::Vector2dF new_value_dip);
+ void SetTotalRootLayerScrollOffset(const gfx::Vector2dF& new_value_dip);
bool CanOnDraw();
// Posts an invalidate with fallback tick. All invalidates posted while an
// invalidate is pending will be posted as a single invalidate after the
« no previous file with comments | « no previous file | android_webview/browser/browser_view_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698