content/browser/android/in_process/synchronous_compositor_impl.cc - Issue 1417893006: sync compositor: pass simple gfx types by const ref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/in_process/synchronous_compositor_impl.cc

Issue 1417893006: sync compositor: pass simple gfx types by const ref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/in_process/synchronous_compositor_impl.h ('k') | content/public/browser/android/synchronous_compositor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/in_process/synchronous_compositor_impl.cc

diff --git a/content/browser/android/in_process/synchronous_compositor_impl.cc b/content/browser/android/in_process/synchronous_compositor_impl.cc

index 4f90a974f28c0a40500525bb14dc138c40a4ea62..9cf1fedc9e9132a29e6a87c06ac51997e3b16a8a 100644

--- a/content/browser/android/in_process/synchronous_compositor_impl.cc

+++ b/content/browser/android/in_process/synchronous_compositor_impl.cc

@@ -174,11 +174,11 @@ void SynchronousCompositorImpl::DidDestroyRendererObjects() {

}

scoped_ptr<cc::CompositorFrame> SynchronousCompositorImpl::DemandDrawHw(

- gfx::Size surface_size,

+ const gfx::Size& surface_size,

const gfx::Transform& transform,

- gfx::Rect viewport,

- gfx::Rect clip,

- gfx::Rect viewport_rect_for_tile_priority,

+ const gfx::Rect& viewport,

+ const gfx::Rect& clip,

+ const gfx::Rect& viewport_rect_for_tile_priority,

const gfx::Transform& transform_for_tile_priority) {

DCHECK(CalledOnValidThread());

DCHECK(output_surface_);