Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 1417893006: sync compositor: pass simple gfx types by const ref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/browser_view_renderer.cc
diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc
index 95faf688a00874a129035fd8dde29c4b00bbc776..fa9ea172dc883e145060c237771bcb75d6cb64ea 100644
--- a/android_webview/browser/browser_view_renderer.cc
+++ b/android_webview/browser/browser_view_renderer.cc
@@ -488,7 +488,7 @@ gfx::Vector2d BrowserViewRenderer::max_scroll_offset() const {
max_scroll_offset_dip_, dip_scale_ * page_scale_factor_));
}
-void BrowserViewRenderer::ScrollTo(gfx::Vector2d scroll_offset) {
+void BrowserViewRenderer::ScrollTo(const gfx::Vector2d& scroll_offset) {
gfx::Vector2d max_offset = max_scroll_offset();
gfx::Vector2dF scroll_offset_dip;
// To preserve the invariant that scrolling to the maximum physical pixel
@@ -542,7 +542,7 @@ void BrowserViewRenderer::DidUpdateContent() {
}
void BrowserViewRenderer::SetTotalRootLayerScrollOffset(
- gfx::Vector2dF scroll_offset_dip) {
+ const gfx::Vector2dF& scroll_offset_dip) {
if (scroll_offset_dip_ == scroll_offset_dip)
return;
scroll_offset_dip_ = scroll_offset_dip;
@@ -627,9 +627,10 @@ BrowserViewRenderer::RootLayerStateAsValue(
return state;
}
-void BrowserViewRenderer::DidOverscroll(gfx::Vector2dF accumulated_overscroll,
- gfx::Vector2dF latest_overscroll_delta,
- gfx::Vector2dF current_fling_velocity) {
+void BrowserViewRenderer::DidOverscroll(
+ const gfx::Vector2dF& accumulated_overscroll,
+ const gfx::Vector2dF& latest_overscroll_delta,
+ const gfx::Vector2dF& current_fling_velocity) {
const float physical_pixel_scale = dip_scale_ * page_scale_factor_;
if (accumulated_overscroll == latest_overscroll_delta)
overscroll_rounding_error_ = gfx::Vector2dF();
« no previous file with comments | « android_webview/browser/browser_view_renderer.h ('k') | android_webview/browser/browser_view_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698