Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1937)

Unified Diff: android_webview/browser/browser_view_renderer_client.h

Issue 1417893006: sync compositor: pass simple gfx types by const ref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/browser_view_renderer.cc ('k') | android_webview/browser/test/rendering_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/browser_view_renderer_client.h
diff --git a/android_webview/browser/browser_view_renderer_client.h b/android_webview/browser/browser_view_renderer_client.h
index a19debdc33cf3ce4feddd65833d8d4a8c520bcf3..064f766aa9c3aaf14fb47daa04b32e7b89640d68 100644
--- a/android_webview/browser/browser_view_renderer_client.h
+++ b/android_webview/browser/browser_view_renderer_client.h
@@ -38,22 +38,22 @@ class BrowserViewRendererClient {
virtual gfx::Point GetLocationOnScreen() = 0;
// Try to set the view's scroll offset to |new_value|.
- virtual void ScrollContainerViewTo(gfx::Vector2d new_value) = 0;
+ virtual void ScrollContainerViewTo(const gfx::Vector2d& new_value) = 0;
// Sets the following:
// view's scroll offset cap to |max_scroll_offset|,
// current contents_size to |contents_size_dip|,
// the current page scale to |page_scale_factor| and page scale limits
// to |min_page_scale_factor|..|max_page_scale_factor|.
- virtual void UpdateScrollState(gfx::Vector2d max_scroll_offset,
- gfx::SizeF contents_size_dip,
+ virtual void UpdateScrollState(const gfx::Vector2d& max_scroll_offset,
+ const gfx::SizeF& contents_size_dip,
float page_scale_factor,
float min_page_scale_factor,
float max_page_scale_factor) = 0;
// Handle overscroll.
- virtual void DidOverscroll(gfx::Vector2d overscroll_delta,
- gfx::Vector2dF overscroll_velocity) = 0;
+ virtual void DidOverscroll(const gfx::Vector2d& overscroll_delta,
+ const gfx::Vector2dF& overscroll_velocity) = 0;
// Visible for testing
// Called when the parent draw constraints in browser view renderer gets
« no previous file with comments | « android_webview/browser/browser_view_renderer.cc ('k') | android_webview/browser/test/rendering_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698