Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414913002: Introduce .isMalformed (Closed)

Created:
5 years, 2 months ago by sigurdm
Modified:
5 years, 2 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce .isMalformed To start a separation between different ways an element can be "wrong". BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/b41dc7ecf79918893b1e4d6c0eabe1627e4b95e6

Patch Set 1 : #

Total comments: 8

Patch Set 2 : Address review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -96 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/placeholder_collector.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/renamer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 5 chunks +15 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 7 chunks +8 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/member_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 10 chunks +13 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 7 chunks +14 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/call_structure.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sigurdm
5 years, 2 months ago (2015-10-20 14:38:01 UTC) #4
Johnni Winther
lgtm https://codereview.chromium.org/1414913002/diff/20001/pkg/compiler/lib/src/elements/elements.dart File pkg/compiler/lib/src/elements/elements.dart (left): https://codereview.chromium.org/1414913002/diff/20001/pkg/compiler/lib/src/elements/elements.dart#oldcode90 pkg/compiler/lib/src/elements/elements.dart:90: const ElementKind('field_list', ElementCategory.NONE); Nice! https://codereview.chromium.org/1414913002/diff/20001/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): ...
5 years, 2 months ago (2015-10-21 07:51:56 UTC) #5
sigurdm
https://codereview.chromium.org/1414913002/diff/20001/pkg/compiler/lib/src/elements/elements.dart File pkg/compiler/lib/src/elements/elements.dart (left): https://codereview.chromium.org/1414913002/diff/20001/pkg/compiler/lib/src/elements/elements.dart#oldcode90 pkg/compiler/lib/src/elements/elements.dart:90: const ElementKind('field_list', ElementCategory.NONE); On 2015/10/21 07:51:56, Johnni Winther wrote: ...
5 years, 2 months ago (2015-10-22 07:33:14 UTC) #6
sigurdm
5 years, 2 months ago (2015-10-22 07:33:42 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
b41dc7ecf79918893b1e4d6c0eabe1627e4b95e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698