pkg/compiler/lib/src/library_loader.dart - Issue 1414913002: Introduce .isMalformed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/library_loader.dart

Issue 1414913002: Introduce .isMalformed (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Address review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/library_loader.dart

diff --git a/pkg/compiler/lib/src/library_loader.dart b/pkg/compiler/lib/src/library_loader.dart

index 5759b52e230bea6d22742a1548fb7e7014b7991c..42bc697ecb990077657295c9a515c97ba09454d4 100644

--- a/pkg/compiler/lib/src/library_loader.dart

+++ b/pkg/compiler/lib/src/library_loader.dart

@@ -975,7 +975,7 @@ class LibraryDependencyNode {

Element existingElement = exportScope[name];

if (existingElement != null && existingElement != element) {

- if (existingElement.isErroneous) {

+ if (existingElement.isMalformed) {

createDuplicateExportMessage(element, exports);

createDuplicateExportDeclMessage(element, exports);

element = existingElement;