Introduce .isMalformed

pkg/compiler/lib/src/dart_backend/placeholder_collector.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart_backend;
 
 class LocalPlaceholder {
   final String identifier;
   final Set<Node> nodes;
   LocalPlaceholder(this.identifier) : nodes = new Set<Node>();
@@ skipping 79 matching lines @@
         // Example: A.f() or f() with 'f' bound to a static function.
         // Also includes new A() or new A.named() which is treated like a
         // static call to a factory.
         visitStaticSend(node);
       }
     }
   }
 
   visitDynamicSend(Send node) {
     final element = elements[node];
-    if (element == null || !element.isErroneous) {
+    if (element == null || !element.isMalformed) {
       collector.tryMakeMemberPlaceholder(node.selector);
     }
   }
 
   visitGetterSend(Send node) {
     final element = elements[node];
     // element == null means dynamic property access.
     if (element == null) {
       collector.tryMakeMemberPlaceholder(node.selector);
-    } else if (element.isErroneous) {
+    } else if (element.isMalformed) {
       collector.makeUnresolvedPlaceholder(node);
       return;
     } else if (element.isPrefix) {
       // Node is prefix part in case of source 'lib.somesetter = 5;'
       collector.makeErasePrefixPlaceholder(node);
     } else if (Elements.isStaticOrTopLevel(element)) {
       // Unqualified or prefixed top level or static.
       collector.makeElementPlaceholder(node.selector, element);
     } else if (!element.isTopLevel) {
       if (element.isInstanceMember) {
@@ skipping 361 matching lines @@
 
   visitNode(Node node) { node.visitChildren(this); }  // We must go deeper.
 
   visitNewExpression(NewExpression node) {
     Send send = node.send;
     DartType type = treeElements.getType(node);
     assert(type != null);
     Element constructor = treeElements[send];
     assert(constructor != null);
     assert(send.receiver == null);
-    if (!Elements.isErroneous(constructor)) {
+    if (!Elements.isMalformed(constructor)) {
       tryMakeConstructorPlaceholder(node.send.selector, constructor);
       // TODO(smok): Should this be in visitNamedArgument?
       // Field names can be exposed as names of optional arguments, e.g.
       // class C {
       //   final field;
       //   C([this.field]);
       // }
       // Do not forget to rename them as well.
       FunctionElement constructorFunction = constructor;
       List<Element> optionalParameters =
@@ skipping 20 matching lines @@
 
   visitSend(Send send) {
     Element element = treeElements[send];
     tryMakePrivateIdentifier(send.selector, element);
     new SendVisitor(this, treeElements).visitSend(send);
     send.visitChildren(this);
   }
 
   visitSendSet(SendSet send) {
     Element element = treeElements[send];
-    if (Elements.isErroneous(element)) {
+    if (Elements.isMalformed(element)) {
       // Complicated case: constructs like receiver.selector++ can resolve
       // to ErroneousElement.  Fortunately, receiver.selector still
       // can be resoved via treeElements[send.selector], that's all
       // that is needed to rename the construct properly.
       element = treeElements[send.selector];
     }
     tryMakePrivateIdentifier(send.selector, element);
     if (element == null) {
       if (send.receiver != null) tryMakeMemberPlaceholder(send.selector);
-    } else if (!element.isErroneous) {
+    } else if (!element.isMalformed) {
       if (Elements.isStaticOrTopLevel(element)) {
         // TODO(smok): Worth investigating why sometimes we get getter/setter
         // here and sometimes abstract field.
         assert(element.isClass || element is VariableElement ||
                element.isAccessor || element.isAbstractField ||
                element.isFunction || element.isTypedef ||
                element is TypeVariableElement);
         makeElementPlaceholder(send.selector, element);
       } else {
         Identifier identifier = send.selector.asIdentifier();
@@ skipping 160 matching lines @@
 
   visitBlock(Block node) {
     for (Node statement in node.statements.nodes) {
       if (statement is VariableDefinitions) {
         makeVarDeclarationTypePlaceholder(statement);
       }
     }
     node.visitChildren(this);
   }
 }