Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: pkg/compiler/lib/src/dart_backend/placeholder_collector.dart

Issue 1414913002: Introduce .isMalformed (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('k') | pkg/compiler/lib/src/dart_backend/renamer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/dart_backend/placeholder_collector.dart
diff --git a/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart b/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart
index 42c15f91a26476e11ae5119b849d40f2948890df..0a2d0e159a700af72b55fd5ddd5ea15e4460f182 100644
--- a/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart
+++ b/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart
@@ -97,7 +97,7 @@ class SendVisitor extends Visitor {
visitDynamicSend(Send node) {
final element = elements[node];
- if (element == null || !element.isErroneous) {
+ if (element == null || !element.isMalformed) {
collector.tryMakeMemberPlaceholder(node.selector);
}
}
@@ -107,7 +107,7 @@ class SendVisitor extends Visitor {
// element == null means dynamic property access.
if (element == null) {
collector.tryMakeMemberPlaceholder(node.selector);
- } else if (element.isErroneous) {
+ } else if (element.isMalformed) {
collector.makeUnresolvedPlaceholder(node);
return;
} else if (element.isPrefix) {
@@ -489,7 +489,7 @@ class PlaceholderCollector extends Visitor {
Element constructor = treeElements[send];
assert(constructor != null);
assert(send.receiver == null);
- if (!Elements.isErroneous(constructor)) {
+ if (!Elements.isMalformed(constructor)) {
tryMakeConstructorPlaceholder(node.send.selector, constructor);
// TODO(smok): Should this be in visitNamedArgument?
// Field names can be exposed as names of optional arguments, e.g.
@@ -530,7 +530,7 @@ class PlaceholderCollector extends Visitor {
visitSendSet(SendSet send) {
Element element = treeElements[send];
- if (Elements.isErroneous(element)) {
+ if (Elements.isMalformed(element)) {
// Complicated case: constructs like receiver.selector++ can resolve
// to ErroneousElement. Fortunately, receiver.selector still
// can be resoved via treeElements[send.selector], that's all
@@ -540,7 +540,7 @@ class PlaceholderCollector extends Visitor {
tryMakePrivateIdentifier(send.selector, element);
if (element == null) {
if (send.receiver != null) tryMakeMemberPlaceholder(send.selector);
- } else if (!element.isErroneous) {
+ } else if (!element.isMalformed) {
if (Elements.isStaticOrTopLevel(element)) {
// TODO(smok): Worth investigating why sometimes we get getter/setter
// here and sometimes abstract field.
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('k') | pkg/compiler/lib/src/dart_backend/renamer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698