Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: pkg/compiler/lib/src/resolution/resolution.dart

Issue 1414913002: Introduce .isMalformed (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | pkg/compiler/lib/src/resolution/send_resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/resolution.dart
diff --git a/pkg/compiler/lib/src/resolution/resolution.dart b/pkg/compiler/lib/src/resolution/resolution.dart
index 2b65e42e00f48965b702a86d27a98400b5601e59..ade41f96391e1e7ab8dfa5d82920b339ca2ee24b 100644
--- a/pkg/compiler/lib/src/resolution/resolution.dart
+++ b/pkg/compiler/lib/src/resolution/resolution.dart
@@ -72,7 +72,7 @@ class ResolverTask extends CompilerTask {
ResolutionImpact resolve(Element element) {
return measure(() {
- if (Elements.isErroneous(element)) {
+ if (Elements.isMalformed(element)) {
// TODO(johnniwinther): Add a predicate for this.
assert(invariant(element, element is! ErroneousElement,
message: "Element $element expected to have parse errors."));
@@ -297,12 +297,12 @@ class ResolverTask extends CompilerTask {
// resolved. This is the only place where the resolver is
// seeing this element.
element.computeType(resolution);
- if (!target.isErroneous) {
+ if (!target.isMalformed) {
registry.registerImplicitSuperCall(target);
}
return registry.worldImpact;
} else {
- assert(element.isDeferredLoaderGetter || element.isErroneous);
+ assert(element.isDeferredLoaderGetter || element.isMalformed);
_ensureTreeElements(element);
return const ResolutionImpact();
}
@@ -831,7 +831,7 @@ class ResolverTask extends CompilerTask {
reporter.internalError(member,
"No abstract field for accessor");
} else if (!identical(lookupElement.kind, ElementKind.ABSTRACT_FIELD)) {
- if (lookupElement.isErroneous || lookupElement.isAmbiguous) return;
+ if (lookupElement.isMalformed || lookupElement.isAmbiguous) return;
reporter.internalError(member,
"Inaccessible abstract field for accessor");
}
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | pkg/compiler/lib/src/resolution/send_resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698