Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: pkg/compiler/lib/src/resolution/send_resolver.dart

Issue 1414913002: Introduce .isMalformed (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/resolution.dart ('k') | pkg/compiler/lib/src/resolution/signatures.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/send_resolver.dart
diff --git a/pkg/compiler/lib/src/resolution/send_resolver.dart b/pkg/compiler/lib/src/resolution/send_resolver.dart
index 479dca04b1ee6cbd4b7525d3691d663ba1e79511..60fca5dad148daace408a35a4784ed7a453bf80a 100644
--- a/pkg/compiler/lib/src/resolution/send_resolver.dart
+++ b/pkg/compiler/lib/src/resolution/send_resolver.dart
@@ -33,7 +33,7 @@ abstract class SendResolverMixin {
return new ConstructorAccessSemantics(
ConstructorAccessKind.NON_CONSTANT_CONSTRUCTOR, constructor, type);
}
- if (constructor.isErroneous) {
+ if (constructor.isMalformed) {
if (constructor is ErroneousElement) {
ErroneousElement error = constructor;
if (error.messageKind == MessageKind.CANNOT_FIND_CONSTRUCTOR) {
@@ -46,7 +46,7 @@ abstract class SendResolverMixin {
} else if (constructor.isRedirectingFactory) {
ConstructorElement effectiveTarget = constructor.effectiveTarget;
if (effectiveTarget == constructor ||
- effectiveTarget.isErroneous ||
+ effectiveTarget.isMalformed ||
(mustBeConstant && !effectiveTarget.isConst)) {
return new ConstructorAccessSemantics(
ConstructorAccessKind.ERRONEOUS_REDIRECTING_FACTORY,
« no previous file with comments | « pkg/compiler/lib/src/resolution/resolution.dart ('k') | pkg/compiler/lib/src/resolution/signatures.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698