Tidy up to enable C4800 on Windows

Tidy up to enable C4800 on Windows

Fixes two incorrect usages of ssize_t/off_t being implicitly converted
to bool. As such, I think it's worth the cost of the additional !! on
BOOL returning Win32 functions.

R=mark@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4b780ba04001fa276a9690a31bf2544d1d28569e

[scottmg, 2015-10-22 21:17:32]

Description was changed from

==========
Tidy up to enable C4800 on Windows

Fixes two incorrect usages of ssize_t/off_t being implicitly converted
to bool incorrectly. As such, I think it's worth the cost of the
additional !! on BOOL returning Win32 functions.

R=mark@chromium.org
==========

to

==========
Tidy up to enable C4800 on Windows

Fixes two incorrect usages of ssize_t/off_t being implicitly converted
to bool. As such, I think it's worth the cost of the additional !! on
BOOL returning Win32 functions.

R=mark@chromium.org
==========

[Mark Mentovai, 2015-10-22 21:22:40]

LGTM

https://codereview.chromium.org/1408123006/diff/20001/client/crashpad_client_...
File client/crashpad_client_win.cc (right):

https://codereview.chromium.org/1408123006/diff/20001/client/crashpad_client_...
client/crashpad_client_win.cc:232: bool set_event_result =
!!SetEvent(g_signal_non_crash_dump);
Ugly, but well, at least it’s not !!::.

https://codereview.chromium.org/1408123006/diff/20001/client/settings.cc
File client/settings.cc (right):

https://codereview.chromium.org/1408123006/diff/20001/client/settings.cc#newc...
client/settings.cc:256: read_result = ReadFile(handle, out_data,
sizeof(*out_data)) >= 0;
Oops, this was my mistake.

== sizeof(*out_data) would match how LoggingReadFile() behaves, right?

https://codereview.chromium.org/1408123006/diff/20001/util/win/critical_secti...
File util/win/critical_section_with_debug_info.cc (right):

https://codereview.chromium.org/1408123006/diff/20001/util/win/critical_secti...
util/win/critical_section_with_debug_info.cc:24: BOOL
CrashpadInitializeCriticalSectionEx(
Switch this to bool, which is what it really returns now…

https://codereview.chromium.org/1408123006/diff/20001/util/win/critical_secti...
util/win/critical_section_with_debug_info.cc:30: bool ret =
…this one can even be BOOL…

https://codereview.chromium.org/1408123006/diff/20001/util/win/critical_secti...
util/win/critical_section_with_debug_info.cc:68: return
!!CrashpadInitializeCriticalSectionEx(
…then you don’t need to change this.

[scottmg, 2015-10-22 21:28:28]

https://codereview.chromium.org/1408123006/diff/20001/client/settings.cc
File client/settings.cc (right):

https://codereview.chromium.org/1408123006/diff/20001/client/settings.cc#newc...
client/settings.cc:256: read_result = ReadFile(handle, out_data,
sizeof(*out_data)) >= 0;
On 2015/10/22 21:22:40, Mark Mentovai wrote:
> Oops, this was my mistake.
> 
> == sizeof(*out_data) would match how LoggingReadFile() behaves, right?

Done.

https://codereview.chromium.org/1408123006/diff/20001/util/win/critical_secti...
File util/win/critical_section_with_debug_info.cc (right):

https://codereview.chromium.org/1408123006/diff/20001/util/win/critical_secti...
util/win/critical_section_with_debug_info.cc:24: BOOL
CrashpadInitializeCriticalSectionEx(
On 2015/10/22 21:22:40, Mark Mentovai wrote:
> Switch this to bool, which is what it really returns now…

Done.

https://codereview.chromium.org/1408123006/diff/20001/util/win/critical_secti...
util/win/critical_section_with_debug_info.cc:30: bool ret =
On 2015/10/22 21:22:40, Mark Mentovai wrote:
> …this one can even be BOOL…

Done.

https://codereview.chromium.org/1408123006/diff/20001/util/win/critical_secti...
util/win/critical_section_with_debug_info.cc:68: return
!!CrashpadInitializeCriticalSectionEx(
On 2015/10/22 21:22:40, Mark Mentovai wrote:
> …then you don’t need to change this.

Done.

[scottmg, 2015-10-22 21:29:54]

https://codereview.chromium.org/1408123006/diff/20001/client/settings.cc
File client/settings.cc (right):

https://codereview.chromium.org/1408123006/diff/20001/client/settings.cc#newc...
client/settings.cc:256: read_result = ReadFile(handle, out_data,
sizeof(*out_data)) >= 0;
On 2015/10/22 21:28:27, scottmg wrote:
> On 2015/10/22 21:22:40, Mark Mentovai wrote:
> > Oops, this was my mistake.
> > 
> > == sizeof(*out_data) would match how LoggingReadFile() behaves, right?
> 
> Done.

Let's hope sizeof(Data) != 0xffffffff bytes!

[scottmg, 2015-10-22 21:32:17]

Committed patchset #3 (id:40001) manually as
4b780ba04001fa276a9690a31bf2544d1d28569e (presubmit successful).