Tidy up to enable C4800 on Windows

util/win/critical_section_with_debug_info.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/win/critical_section_with_debug_info.h"
 
 #include "base/logging.h"
 #include "util/win/get_function.h"
 
 namespace crashpad {
 
 namespace {
 
 BOOL CrashpadInitializeCriticalSectionEx(

[Mark Mentovai, 2015/10/22 21:22:40]

Switch this to bool, which is what it really returns now…

[scottmg, 2015/10/22 21:28:27]

Done.

     CRITICAL_SECTION* critical_section,
     DWORD spin_count,
     DWORD flags) {
   static const auto initialize_critical_section_ex =
       GET_FUNCTION_REQUIRED(L"kernel32.dll", ::InitializeCriticalSectionEx);
   bool ret =

[Mark Mentovai, 2015/10/22 21:22:40]

…this one can even be BOOL…

[scottmg, 2015/10/22 21:28:27]

Done.

-      initialize_critical_section_ex(critical_section, spin_count, flags);
+      !!initialize_critical_section_ex(critical_section, spin_count, flags);
   if (!ret) {
     PLOG(ERROR) << "InitializeCriticalSectionEx";
     return false;
   }
   return true;
 }
 
 }  // namespace
 
 bool InitializeCriticalSectionWithDebugInfoIfPossible(
@@ skipping 16 matching lines @@
   const DWORD major_version = LOBYTE(LOWORD(version));
   const DWORD minor_version = HIBYTE(LOWORD(version));
   const bool win7_or_lower =
       major_version < 6 || (major_version == 6 && minor_version <= 1);
 
   if (win7_or_lower) {
     InitializeCriticalSection(critical_section);
     return true;
   }
 
-  return CrashpadInitializeCriticalSectionEx(
-      critical_section, 0, RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO);
+  return !!CrashpadInitializeCriticalSectionEx(

[Mark Mentovai, 2015/10/22 21:22:40]

…then you don’t need to change this.

[scottmg, 2015/10/22 21:28:27]

Done.

+              critical_section, 0, RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO);
 }
 
 }  // namespace crashpad