Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: util/file/file_io_win.cc

Issue 1408123006: Tidy up to enable C4800 on Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « snapshot/win/system_snapshot_win.cc ('k') | util/win/critical_section_with_debug_info.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 if (!SetEndOfFile(file)) { 226 if (!SetEndOfFile(file)) {
227 PLOG(ERROR) << "SetEndOfFile"; 227 PLOG(ERROR) << "SetEndOfFile";
228 return false; 228 return false;
229 } 229 }
230 return true; 230 return true;
231 } 231 }
232 232
233 bool LoggingCloseFile(FileHandle file) { 233 bool LoggingCloseFile(FileHandle file) {
234 BOOL rv = CloseHandle(file); 234 BOOL rv = CloseHandle(file);
235 PLOG_IF(ERROR, !rv) << "CloseHandle"; 235 PLOG_IF(ERROR, !rv) << "CloseHandle";
236 return rv; 236 return !!rv;
237 } 237 }
238 238
239 } // namespace crashpad 239 } // namespace crashpad
OLDNEW
« no previous file with comments | « snapshot/win/system_snapshot_win.cc ('k') | util/win/critical_section_with_debug_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698