Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: client/settings.cc

Issue 1408123006: Tidy up to enable C4800 on Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/crashpad_client_win.cc ('k') | minidump/minidump_file_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/settings.cc
diff --git a/client/settings.cc b/client/settings.cc
index 7f126ad70d12e79d3ae70a4f1cadcd14e4d908d5..6d4640772f8b58fae393286b696277d81dee49c3 100644
--- a/client/settings.cc
+++ b/client/settings.cc
@@ -250,10 +250,12 @@ bool Settings::ReadSettings(FileHandle handle,
return false;
bool read_result;
- if (log_read_error)
+ if (log_read_error) {
read_result = LoggingReadFile(handle, out_data, sizeof(*out_data));
- else
- read_result = ReadFile(handle, out_data, sizeof(*out_data));
+ } else {
+ read_result =
+ ReadFile(handle, out_data, sizeof(*out_data)) == sizeof(*out_data);
+ }
if (!read_result)
return false;
« no previous file with comments | « client/crashpad_client_win.cc ('k') | minidump/minidump_file_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698