minidump/minidump_file_writer.cc - Issue 1408123006: Tidy up to enable C4800 on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_file_writer.cc

Issue 1408123006: Tidy up to enable C4800 on Windows (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: . Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_file_writer.cc

diff --git a/minidump/minidump_file_writer.cc b/minidump/minidump_file_writer.cc

index ff3531918eb13f9e6681f6c65e51b1669ef70165..2b13433ab956f69bb082c7ea11878c1f92e210ee 100644

--- a/minidump/minidump_file_writer.cc

+++ b/minidump/minidump_file_writer.cc

@@ -173,7 +173,7 @@ bool MinidumpFileWriter::WriteEverything(FileWriterInterface* file_writer) {

// Seek back to the end of the file, in case some non-minidump content will be

// written to the file after the minidump content.

- return file_writer->Seek(end_offset, SEEK_SET);

+ return file_writer->Seek(end_offset, SEEK_SET) >= 0;

}

bool MinidumpFileWriter::Freeze() {

« no previous file with comments | « client/settings.cc ('k') | minidump/minidump_module_writer_test.cc » ('j') | no next file with comments »